[GitHub] [jackrabbit-oak] AngelaFabregues commented on a diff in pull request #586: OAK-9792 - The maximum number of search results per page is increased…

[GitBox <gi...@apache.org>]

AngelaFabregues commented on code in PR #586:
URL: https://github.com/apache/jackrabbit-oak/pull/586#discussion_r888249168


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDefinition.java:
##########
@@ -130,6 +136,7 @@ public ElasticIndexDefinition(NodeState root, NodeState defn, String indexPath,
         this.bulkRetriesBackoff = getOptionalValue(defn, BULK_RETRIES_BACKOFF, BULK_RETRIES_BACKOFF_DEFAULT);
         this.numberOfShards = getOptionalValue(defn, NUMBER_OF_SHARDS, NUMBER_OF_SHARDS_DEFAULT);
         this.numberOfReplicas = getOptionalValue(defn, NUMBER_OF_REPLICAS, NUMBER_OF_REPLICAS_DEFAULT);
+        this.maxResultWindow = getOptionalValue(defn, MAX_RESULT_WINDOW, AEM_QUERY_MAX);

Review Comment:
   Thanks. In parallel, I've also changed the approach to default to the Elasticsearch default value and to keep it configurable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org