You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/15 08:53:53 UTC
[GitHub] [flink] tsreaper opened a new pull request #17794: [FLINK-24885][table-runtime] Fix NullPointerException in SinkConversion and OutputConversion when row time is null
tsreaper opened a new pull request #17794:
URL: https://github.com/apache/flink/pull/17794
## What is the purpose of the change
Currently `SinkConversion` (generated code) and `OutputConversionOperator` are not handling the case when row time is null. This PR fixes the issue.
## Brief change log
- Fix NullPointerException in SinkConversion and OutputConversion when row time is null.
## Verifying this change
This change added tests and can be verified by running the added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17794: [FLINK-24885][table-runtime] Fix NullPointerException in SinkConversion and OutputConversion when row time is null
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17794:
URL: https://github.com/apache/flink/pull/17794#issuecomment-968670345
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6187b16c51fad3fb3ac4180736999804f84c9871 (Mon Nov 15 08:58:59 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24885).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17794: [FLINK-24885][table-runtime] Fix NullPointerException in SinkConversion and OutputConversion when row time is null
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17794:
URL: https://github.com/apache/flink/pull/17794#issuecomment-968669934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6187b16c51fad3fb3ac4180736999804f84c9871",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26515",
"triggerID" : "6187b16c51fad3fb3ac4180736999804f84c9871",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6187b16c51fad3fb3ac4180736999804f84c9871 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26515)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on pull request #17794: [FLINK-24885][table-runtime] Fix NullPointerException in SinkConversion and OutputConversion when row time is null
Posted by GitBox <gi...@apache.org>.
tsreaper commented on pull request #17794:
URL: https://github.com/apache/flink/pull/17794#issuecomment-969648661
> I'm not sure if the sink is the only location that breaks with rowtime being NULL. I'm wondering whether we should allow this at all. It could cause a couple of issues in downstream operators. Maybe it is better to make the column `NOT NULL` during the schema resolution?
I've searched the usage and see a few more methods directly calling `getMillisecond` without checking for nulls. I think we should unify the behavior for records with rowtime being null (for example we just discard the records) instead of throwing exceptions because this is not friendly for streaming job users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17794: [FLINK-24885][table-runtime] Fix NullPointerException in SinkConversion and OutputConversion when row time is null
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17794:
URL: https://github.com/apache/flink/pull/17794#issuecomment-968669934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6187b16c51fad3fb3ac4180736999804f84c9871",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6187b16c51fad3fb3ac4180736999804f84c9871",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6187b16c51fad3fb3ac4180736999804f84c9871 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17794: [FLINK-24885][table-runtime] Fix NullPointerException in SinkConversion and OutputConversion when row time is null
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17794:
URL: https://github.com/apache/flink/pull/17794#issuecomment-968669934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6187b16c51fad3fb3ac4180736999804f84c9871",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26515",
"triggerID" : "6187b16c51fad3fb3ac4180736999804f84c9871",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6187b16c51fad3fb3ac4180736999804f84c9871 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26515)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org