You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/12/24 09:10:01 UTC

[doris] 09/15: [Fix](multi catalog)Fix VFileScanner file not found status bug. #15226

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 4036ac38cfe46f6233ecae1128565b7bea1dea2f
Author: Jibing-Li <64...@users.noreply.github.com>
AuthorDate: Fri Dec 23 16:45:54 2022 +0800

    [Fix](multi catalog)Fix VFileScanner file not found status bug. #15226
    
    The if condition to check NOT FOUND status for VFileScanner is incorrect, fix it.
---
 be/src/vec/exec/scan/scanner_scheduler.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/be/src/vec/exec/scan/scanner_scheduler.cpp b/be/src/vec/exec/scan/scanner_scheduler.cpp
index 0a8dd47932..e67ff364be 100644
--- a/be/src/vec/exec/scan/scanner_scheduler.cpp
+++ b/be/src/vec/exec/scan/scanner_scheduler.cpp
@@ -235,8 +235,11 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler* scheduler, ScannerContext
         VLOG_ROW << "VOlapScanNode input rows: " << block->rows() << ", eos: " << eos;
         // The VFileScanner for external table may try to open not exist files,
         // Because FE file cache for external table may out of date.
+        // So, NOT_FOUND for VFileScanner is not a fail case.
+        // Will remove this after file reader refactor.
         if (!status.ok() && (typeid(*scanner) != typeid(doris::vectorized::VFileScanner) ||
-                             !status.is_not_found())) {
+                             (typeid(*scanner) == typeid(doris::vectorized::VFileScanner) &&
+                              !status.is_not_found()))) {
             LOG(WARNING) << "Scan thread read VOlapScanner failed: " << status.to_string();
             // Add block ptr in blocks, prevent mem leak in read failed
             blocks.push_back(block);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org