[GitHub] [incubator-mxnet] szha commented on a change in pull request #20249: [v1.x] ONNX Add an option to un-interleave BERT

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #20249:
URL: https://github.com/apache/incubator-mxnet/pull/20249#discussion_r627842716



##########
File path: python/mxnet/onnx/mx2onnx/_export_model.py
##########
@@ -83,6 +83,11 @@ def export_model(sym, params, in_shapes=None, in_types=np.float32,
         This is the old name of in_types. We keep this parameter name for backward compatibility
     in_shapes : List of tuple
         This is the old name of in_shapes. We keep this parameter name for backward compatibility
+    model_specific_logics : str
+        Specifies if model-specific conversion logic should be used. Refer to ./_op_translations/
+    cheat_sheet : dict of str to str
+        This is a dict that stors some hyperparameters values or additional info about the model that
+        would be used in model-specific conversion functions

Review comment:
       these options are semantically unclear and hard to maintain




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org