You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/29 16:18:36 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request #2121: minor: replace array_equals in case evaluation with eq_dyn from arrow-rs

alamb opened a new pull request #2121:
URL: https://github.com/apache/arrow-datafusion/pull/2121


   # Which issue does this PR close?
   
   N/A
   
    # Rationale for this change
   Some features have been added to arrow-rs that mean we no longer have to have this code in datafusion. I noticed this while working on https://github.com/apache/arrow-datafusion/pull/2118
   
   # What changes are included in this PR?
   use `eq_dyn` rather than re-creating part of it in DataFusion
   
   
   # Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #2121: minor: replace array_equals in case evaluation with eq_dyn from arrow-rs

Posted by GitBox <gi...@apache.org>.

alamb commented on pull request #2121:
URL: https://github.com/apache/arrow-datafusion/pull/2121#issuecomment-1083420988


   > It might even be possible to use the eq_dyn_scalar APIs in many cases instead of into_array 🤔
   
   I started playing around with this. It would indeed be cool -- will see what I can do


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] yjshen merged pull request #2121: minor: replace array_equals in case evaluation with eq_dyn from arrow-rs

Posted by GitBox <gi...@apache.org>.

yjshen merged pull request #2121:
URL: https://github.com/apache/arrow-datafusion/pull/2121


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org