You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/25 02:28:21 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #22397: Improve DistSQL DROP SHADOW RULE
Pace2Car opened a new pull request, #22397:
URL: https://github.com/apache/shardingsphere/pull/22397
For #22358.
Changes proposed in this pull request:
- Remove unused algorithms while dropping a shadow rule
- Add related test cases
- Update document
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22397: Improve DistSQL DROP SHADOW RULE
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22397:
URL: https://github.com/apache/shardingsphere/pull/22397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Pace2Car commented on pull request #22397: Improve DistSQL DROP SHADOW RULE
Posted by GitBox <gi...@apache.org>.
Pace2Car commented on PR #22397:
URL: https://github.com/apache/shardingsphere/pull/22397#issuecomment-1326958692
please add lables: feature: DistSQL feature: shadow type: enhancement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22397: Improve DistSQL DROP SHADOW RULE
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22397:
URL: https://github.com/apache/shardingsphere/pull/22397#issuecomment-1326972252
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22397?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22397](https://codecov.io/gh/apache/shardingsphere/pull/22397?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3ecd30) into [master](https://codecov.io/gh/apache/shardingsphere/commit/77c1aceea3c21a472e5ffaf2092dfdde412884d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77c1ace) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #22397 +/- ##
============================================
- Coverage 51.07% 51.01% -0.07%
- Complexity 2498 2501 +3
============================================
Files 4166 4172 +6
Lines 57888 57989 +101
Branches 9838 9857 +19
============================================
+ Hits 29568 29584 +16
- Misses 25788 25879 +91
+ Partials 2532 2526 -6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...andler/update/DropEncryptRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9Ecm9wRW5jcnlwdFJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `79.31% <100.00%> (+5.97%)` | :arrow_up: |
| [...handler/update/DropShadowRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvRHJvcFNoYWRvd1J1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `77.77% <100.00%> (+7.77%)` | :arrow_up: |
| [...andler/update/AbstractDropShardingRuleUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Fic3RyYWN0RHJvcFNoYXJkaW5nUnVsZVVwZGF0ZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...er/update/DropDefaultStrategyStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BEZWZhdWx0U3RyYXRlZ3lTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `75.86% <100.00%> (+8.00%)` | :arrow_up: |
| [.../update/DropShardingTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BTaGFyZGluZ1RhYmxlUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `78.46% <100.00%> (+1.12%)` | :arrow_up: |
| [...e/sharding/checker/audit/ShardingAuditChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvY2hlY2tlci9hdWRpdC9TaGFyZGluZ0F1ZGl0Q2hlY2tlci5qYXZh) | `64.00% <0.00%> (-3.86%)` | :arrow_down: |
| [...rdinator/subscriber/DatabaseChangedSubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3Ivc3Vic2NyaWJlci9EYXRhYmFzZUNoYW5nZWRTdWJzY3JpYmVyLmphdmE=) | `23.52% <0.00%> (-3.14%)` | :arrow_down: |
| [...persist/data/ShardingSphereDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3QvZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `5.55% <0.00%> (-2.14%)` | :arrow_down: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `53.84% <0.00%> (-2.06%)` | :arrow_down: |
| [...egistry/data/ShardingSphereDataChangedWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3IvcmVnaXN0cnkvZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFDaGFuZ2VkV2F0Y2hlci5qYXZh) | `3.63% <0.00%> (-1.13%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/shardingsphere/pull/22397/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org