You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/05/19 10:26:32 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #944: HDDS-3609. Avoid to use Hadoop3.x IOUtils in Ozone Client
elek opened a new pull request #944:
URL: https://github.com/apache/hadoop-ozone/pull/944
## What changes were proposed in this pull request?
To support Hadoop 2.x it's better to avoid to use Hadoop 3.x specific utility methods from IOUtils
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3609
## How was this patch tested?
With "push & hope" method on my fork :-P
https://github.com/elek/hadoop-ozone/actions/runs/108204343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #944: HDDS-3609. Avoid to use Hadoop3.x IOUtils in Ozone Client
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #944:
URL: https://github.com/apache/hadoop-ozone/pull/944#issuecomment-632572966
Thanks the feedback @adoroszlai
I started to write my first answer yesterday: "good idea, let me check the version of IO commons used by hadoop 2.x"
But I started to think. Do we really need one additional dependency? IOUtils is better than guava but we need to shade all the dependencies on the client side. I agree with the server side, let's use common, but client side, It can be better to maintain our own logic.
But *currently* we have IOUtils on the classpath anyway. I updated the patch based on the suggestions, but in the future we can revisit that approach (using IOUtils) when we agree to remove IOUtils from the dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #944: HDDS-3609. Avoid to use Hadoop3.x IOUtils in Ozone Client
Posted by GitBox <gi...@apache.org>.
elek merged pull request #944:
URL: https://github.com/apache/hadoop-ozone/pull/944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #944: HDDS-3609. Avoid to use Hadoop3.x IOUtils in Ozone Client
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #944:
URL: https://github.com/apache/hadoop-ozone/pull/944#issuecomment-635861656
It turned out that using IOUtils is unsafe. With using Hadoop 2.7.7:
With the final patch I got:
```
nm_1 | java.lang.NoSuchMethodError: org.apache.commons.io.IOUtils.closeQuietly([Ljava/io/Closeable;)V
```
I will recreate the original patch (forking the close utility) if no objections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org