You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/24 13:25:19 UTC

[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #308: [YUNIKORN-814] The template of non-leaf queue should not be override …

wilfred-s commented on a change in pull request #308:
URL: https://github.com/apache/incubator-yunikorn-core/pull/308#discussion_r694846842



##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -656,7 +656,10 @@ func (sq *Queue) addChildQueue(child *Queue) error {
 		}
 		// managed (configured) leaf queue can't use template
 	} else {
-		child.template = sq.template
+		// don't override the template of non-leaf queue
+		if child.template == nil {

Review comment:
       Please add logging for this case, something like inheriting child template for queue...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org