DO NOT REPLY [Bug 17509] New: - Jasper erroneously optimises BodyTag instances with no body

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17509>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17509

Jasper erroneously optimises BodyTag instances with no body

           Summary: Jasper erroneously optimises BodyTag instances with no
                    body
           Product: Tomcat 4
           Version: 4.1.18
          Platform: Macintosh
        OS/Version: MacOS X
            Status: NEW
          Severity: Critical
          Priority: Other
         Component: Jasper
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: James_Sloan@alumni.hmc.edu


Starting with Tomcat 4.0, Jasper is checking to see whether or not a BodyTag's body is empty before emitting the code to call doInitBody(), setBodyContent(), and doAfterBody().  If it is, it skips the call, ignores the result of doStartTag(), and simply emits a call to doEndTag().

The problem occurs for tags which contain logic in doAfterBody() which might emit results even if the body is empty.  Our project contains several tags which, for reuse purposes, may either take their parameter(s) as subelements or as attributes.  If the body is empty, the attribute value will be used in its stead.

When I attempted to install our application using Tomcat 4.1.18, none of these tags actually did anything.  :-)

A simple removal of the check for a null body fixed the problem for me.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org