You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/18 05:45:00 UTC
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1064: fix: when enable or disable existing SSL, an error occurred
codecov-io edited a comment on pull request #1064:
URL: https://github.com/apache/apisix-dashboard/pull/1064#issuecomment-747536592
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr&el=h1) Report
> Merging [#1064](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr&el=desc) (91bcec0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/303cc5612feac82dc27305f1c29762262693eda5?el=desc) (303cc56) will **increase** coverage by `0.78%`.
> The diff coverage is `84.61%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1064/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 40.13% 40.92% +0.78%
==========================================
Files 26 27 +1
Lines 1572 1603 +31
==========================================
+ Hits 631 656 +25
- Misses 850 854 +4
- Partials 91 93 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1064/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.50% <60.00%> (+1.07%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1064/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `29.54% <66.66%> (+0.06%)` | :arrow_up: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1064/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `95.65% <100.00%> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1064/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr&el=footer). Last update [303cc56...2088687](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org