You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jacksontj <gi...@git.apache.org> on 2015/07/08 02:57:29 UTC
[GitHub] trafficserver pull request: Add tests for TS-3725
GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/242
Add tests for TS-3725
This includes allowing loopback addresses in hosts files. @SolidWallOfCode had some concerns, but from my testing I can't see any reason why we wouldn't allow this here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacksontj/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #242
----
commit 5a3b1395659d1abb482890ab2de09edcd35d9cb9
Author: Thomas Jackson <ja...@apache.org>
Date: 2015-07-07T02:21:53Z
Allow for loopback addresses in a hosts file
commit 214cd38036955d0305605e8de3ee49a2360fc567
Author: Thomas Jackson <ja...@apache.org>
Date: 2015-07-07T02:50:23Z
Add basic tests for the Hosts file implementation in ATS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add tests for TS-3725
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add tests for TS-3725
Posted by jacksontj <gi...@git.apache.org>.
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/242#issuecomment-119399795
From some chats with @SolidWallOfCode the issue he saw may have been due to how he implemented the feature previously (at a higher layer)-- but we aren't sure. In my local testing I'm unable to produce any issues with having the host file return loopback addresses, but they aren't guaranteed to be exhaustive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---