You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/02/17 11:48:55 UTC
[GitHub] [incubator-uniffle] advancedxy opened a new issue, #627: [Bug] operator should set coordinator and shuffle server's ports to the spec rather a fixed value
advancedxy opened a new issue, #627:
URL: https://github.com/apache/incubator-uniffle/issues/627
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### Describe the bug
As reported by https://github.com/apache/incubator-uniffle/discussions/620, it's related to code:
```
func generateMainContainerPorts(rss *unifflev1alpha1.RemoteShuffleService) []corev1.ContainerPort {
ports := []corev1.ContainerPort{
{
ContainerPort: controllerconstants.ContainerCoordinatorRPCPort,
Protocol: corev1.ProtocolTCP,
},
{
ContainerPort: controllerconstants.ContainerCoordinatorHTTPPort,
Protocol: corev1.ProtocolTCP,
},
}
ports = append(ports, rss.Spec.Coordinator.Ports...)
return ports
}
```
The coordinator and shuffle server's container port is fixed to the default constants. It should matches the port specified in the RSS spec.
### Affects Version(s)
master,0.7.0
### Uniffle Server Log Output
_No response_
### Uniffle Engine Log Output
_No response_
### Uniffle Server Configurations
_No response_
### Uniffle Engine Configurations
_No response_
### Additional context
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #627: [Bug] operator should set coordinator and shuffle server's ports to the spec rather a fixed value
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #627:
URL: https://github.com/apache/incubator-uniffle/issues/627#issuecomment-1434531064
There's another problem about the operator:
```
func GenerateAddresses(rss *unifflev1alpha1.RemoteShuffleService) string {
var names []string
for i := 0; i < int(*rss.Spec.Coordinator.Count); i++ {
name := GenerateNameByIndex(rss, i)
serviceName := appendHeadless(name)
current := fmt.Sprintf("%v:%v", serviceName, controllerconstants.ContainerShuffleServerRPCPort)
names = append(names, current)
}
return strings.Join(names, ",")
}
```
It uses wrong constants, and it should also be updated to use the port in the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy closed issue #627: [Bug] operator should set coordinator and shuffle server's ports to the spec rather a fixed value
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy closed issue #627: [Bug] operator should set coordinator and shuffle server's ports to the spec rather a fixed value
URL: https://github.com/apache/incubator-uniffle/issues/627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org