[jira] [Created] (REEF-441) Fix violations of VisibilityModifier checkstyle

["Mariia Mykhailova (JIRA)" <ji...@apache.org>]

Mariia Mykhailova created REEF-441:
--------------------------------------

             Summary: Fix violations of VisibilityModifier checkstyle
                 Key: REEF-441
                 URL: https://issues.apache.org/jira/browse/REEF-441
             Project: REEF
          Issue Type: Sub-task
          Components: All
            Reporter: Mariia Mykhailova
            Assignee: Mariia Mykhailova
            Priority: Minor
             Fix For: 0.12


http://checkstyle.sourceforge.net/config_design.html#VisibilityModifier
"Only static final, immutable or annotated by specified annotation members may be public; other class members must be private unless the property protectedAllowed or packageAllowed is set. "

We have around 100 violations of various nature:

* Some, like endIndicators and startIndicators in org/apache/reef/util/logging/LogParser.java, are static but not final and look like they should be final
* Some, like in org/apache/reef/common/AbstractFailure.java, already have getters but are protected or default visibility instead of private
* Some, like handler and message in org/apache/reef/runtime/common/utils/DispatchingEStage.java, have no getters and are public

Fixing public members requires two-stage change with deprecation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)