You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ramkumar Aiyengar (JIRA)" <ji...@apache.org> on 2015/01/10 22:34:34 UTC
[jira] [Updated] (SOLR-6902) Use JUnit rules instead of inheritance
with distributed Solr tests to allow for multiple tests without the same
class
[ https://issues.apache.org/jira/browse/SOLR-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Aiyengar updated SOLR-6902:
------------------------------------
Attachment: SOLR-6902.patch
The patch is in the pull request, but if you need it as a patch file attached, here you go, I have attached it now.
(I know you mentioned putting in a patch file instead of a PR in a different issue, it's just that I personally find it easier/better to use git + pr as a workflow, and the PR integration to dev-list and mails like http://markmail.org/message/whjq4u2zkpjoh4b2 seem to suggest that it's an accepted method. That said, if a committer requests it as a patch file, I am happy to oblige..)
> Use JUnit rules instead of inheritance with distributed Solr tests to allow for multiple tests without the same class
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6902
> URL: https://issues.apache.org/jira/browse/SOLR-6902
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Reporter: Ramkumar Aiyengar
> Priority: Minor
> Attachments: SOLR-6902.patch
>
>
> Finally got annoyed enough with too many things being clubbed into one test method in all distributed Solr tests (anything inheriting from {{BaseDistributedSearchTestCase}} and currently implementing {{doTest}})..
> This just lays the groundwork really for allowing multiple test methods within the same class, and doesn't split tests as yet or flatten the inheritance hierarchy (when abused for doing multiple tests), as this touches a lot of files by itself. For that reason, the sooner this is picked up the better..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org