You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2022/07/26 11:24:30 UTC
[GitHub] [mesos] andreaspeters opened a new pull request, #444: UPDATE: ruby version to fix bundle incompatibility.
andreaspeters opened a new pull request, #444:
URL: https://github.com/apache/mesos/pull/444
With these PR I would like to fix the website build error. The reason why I do not update to the newest ruby version is, that we will get a lot of "deprecated" error messages. So, for now it's working, but we still have an issue here.
https://ci-builds.apache.org/job/Mesos/job/Mesos-Websitebot/1326/consoleFull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
cf-natali commented on PR #444:
URL: https://github.com/apache/mesos/pull/444#issuecomment-1207376803
Merged, thanks Andreas!
Looking forward to updated Docker images :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
cf-natali commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931535237
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
Yes, I think it's reasonable.
We should merge this, and separately see if we can update the docker image to a more recent Ubuntu version, e g. 20.04 or 22.04.
I started working on updating other containers a couple weeks ago, it's not too much work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on PR #444:
URL: https://github.com/apache/mesos/pull/444#issuecomment-1207404624
And thanks for the merge. :-D But it looks like there is a other issue. But I think it have nothing to do with our change.
https://ci-builds.apache.org/blue/organizations/jenkins/Mesos%2FMesos-Websitebot/detail/Mesos-Websitebot/1337/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931540824
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
> and separately see if we can update the docker image to a more recent Ubuntu version, e g. 20.04 or 22.04.
:+1: definitely. Which containers do you already have on your hands? Then I can start to help with others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on PR #444:
URL: https://github.com/apache/mesos/pull/444#issuecomment-1207404154
The docker image to build "our" website, depends on the mesos-build docker images. As I see, the website build job compile mesos to create the API docs. So, I think I have to wait until you are finish with the mesos-build docker image. :sweat_smile: So, first I will update the mesos-centos image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali merged pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
cf-natali merged PR #444:
URL: https://github.com/apache/mesos/pull/444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
cf-natali commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931587130
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
I started looking at https://hub.docker.com/r/mesos/mesos-tidy and https://hub.docker.com/r/mesos/mesos-build
If you could update this image used for the website build that'd be great, and if you have time maybe also updating the CentOS image https://hub.docker.com/r/mesos/mesos-centos
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
cf-natali commented on PR #444:
URL: https://github.com/apache/mesos/pull/444#issuecomment-1207439954
Yep indeed, I think I know what the issue is, I'll fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931163726
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
Right, but the ruby version in the official Ubuntu 16.04 repository are to old.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] qianzhangxa commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
qianzhangxa commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931038005
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
I think with `apt-get` we can also install a specific version of Ruby, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931589346
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
:+1: What do u think about to migrate from centos to almalinux? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] qianzhangxa commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
qianzhangxa commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931660363
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
If you guys already started working on updating the images, then do we still need to merge this PR? I mean once the images are updated, we would need to revert the changes of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931863076
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
Good question! Depends the mesos-build image and it's impact. If it's done and all the build jobs are still working, then it should be very easy to update the "website build" dockerfile. What do u think @cf-natali ? First merge this PR to fix the website?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
cf-natali commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r932696529
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
I think it makes sense to merge, this way we're sure the website build is fixed.
Upgrading to a new Ubuntu release might be more work, so I'd rather do it separately, taking the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a diff in pull request #444: UPDATE: ruby version to fix bundle incompatibility.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on code in PR #444:
URL: https://github.com/apache/mesos/pull/444#discussion_r931163726
##########
support/mesos-website/Dockerfile:
##########
@@ -13,14 +13,16 @@ USER root
RUN apt-get update && \
apt-get install -y --no-install-recommends \
doxygen \
- locales \
- ruby \
- ruby-dev \
- rubygems && \
Review Comment:
Right, but the ruby version in the official Ubuntu 16.04 repository is to old.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org