You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/07 09:32:12 UTC
[GitHub] [incubator-seatunnel] chenhu opened a new pull request, #1819: https://github.com/apache/incubator-seatunnel/issues/1818
chenhu opened a new pull request, #1819:
URL: https://github.com/apache/incubator-seatunnel/pull/1819
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1819: [Bugfix] [seatunnel-core-spark] plugin jars can't be added correctly in SparkStarter
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1819:
URL: https://github.com/apache/incubator-seatunnel/pull/1819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1819: https://github.com/apache/incubator-seatunnel/issues/1818
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #1819:
URL: https://github.com/apache/incubator-seatunnel/pull/1819#issuecomment-1120176475
@chenhu Please modify the pr title, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a diff in pull request #1819: https://github.com/apache/incubator-seatunnel/issues/1818
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on code in PR #1819:
URL: https://github.com/apache/incubator-seatunnel/pull/1819#discussion_r867331397
##########
seatunnel-core/seatunnel-core-spark/src/main/java/org/apache/seatunnel/core/spark/SparkStarter.java:
##########
@@ -191,11 +191,15 @@ private List<Path> getPluginsJarDependencies() throws IOException {
if (!Files.exists(pluginRootDir) || !Files.isDirectory(pluginRootDir)) {
return Collections.emptyList();
}
+ //my test code
+ Path pluginJarPath = Paths.get("/Users/chenhu/projects/org/apache/seatunnel/seatunnel-common/plugins/oracle/lib/ojdbc8.jar");
+
Review Comment:
This path seems to be problematic, not general enough, please modify it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] chenhu commented on a diff in pull request #1819: https://github.com/apache/incubator-seatunnel/issues/1818
Posted by GitBox <gi...@apache.org>.
chenhu commented on code in PR #1819:
URL: https://github.com/apache/incubator-seatunnel/pull/1819#discussion_r867332199
##########
seatunnel-core/seatunnel-core-spark/src/main/java/org/apache/seatunnel/core/spark/SparkStarter.java:
##########
@@ -191,11 +191,15 @@ private List<Path> getPluginsJarDependencies() throws IOException {
if (!Files.exists(pluginRootDir) || !Files.isDirectory(pluginRootDir)) {
return Collections.emptyList();
}
+ //my test code
+ Path pluginJarPath = Paths.get("/Users/chenhu/projects/org/apache/seatunnel/seatunnel-common/plugins/oracle/lib/ojdbc8.jar");
+
Review Comment:
o, my mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] chenhu commented on pull request #1819: [Bugfix] [seatunnel-core-spark] plugin jars can't be loaded correctly
Posted by GitBox <gi...@apache.org>.
chenhu commented on PR #1819:
URL: https://github.com/apache/incubator-seatunnel/pull/1819#issuecomment-1120178685
>
the tile changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org