You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/17 12:29:41 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #3462: Aws2 quarkus client ddb refactor
JiriOndrusek opened a new pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462
fixes https://github.com/apache/camel-quarkus/issues/3236
Requires https://github.com/apache/camel-quarkus/pull/3458 to be merged (it contains the forst commit from this PR)
This commit refactores aws2-quarkus-client-ddb. With this change, module will copy sources from aws2-ddb module and won't duplicate them.
S3 module is fixed by the PR which contains the first commit.
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462#issuecomment-1014681074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462#issuecomment-1015204431
I don't know too. Let's have a successful CI build and merge this PR then. Thanks for fixing :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462#issuecomment-1015147145
@aldettinger Yes. https://github.com/apache/camel-quarkus/pull/3458 should be merged first. Hopefully there should not be needed any rebase of this PR, because the first commit is the same in both PRs.
I wrote that into the summary:
```
Requires #3458 to be merged (it contains the forst commit from this PR)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462#issuecomment-1015179790
@JiriOndrusek I've merged the other PR and now this one has conflict. Could you please check ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462#issuecomment-1015198201
@aldettinger it should be fixed. Eventhough I cherrypicked the second commitr from the original PR and there was no conflict. I'm not sure why it didn't work automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger removed a comment on pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
aldettinger removed a comment on pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462#issuecomment-1014681177
I'm not sure whether this PR contains both ddb and S3 ? Shouldn't we merge #3458 first ? Or maybe rebase ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3462: Aws2 quarkus client ddb refactor
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #3462:
URL: https://github.com/apache/camel-quarkus/pull/3462#issuecomment-1015192476
I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org