You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/12/19 23:53:33 UTC
[kudu-CR] [tests] add /threadz page to PeriodicWebUIChecker
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12114
Change subject: [tests] add /threadz page to PeriodicWebUIChecker
......................................................................
[tests] add /threadz page to PeriodicWebUIChecker
With this patch, the PeriodicWebUIChecker periodically fetches
the /threadz?group=all page of the embedded Web server along with
other diagnostic pages.
Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
---
M src/kudu/integration-tests/linked_list-test-util.h
1 file changed, 28 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/12114/1
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] add /threadz pages to PeriodicWebUIChecker
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12114 )
Change subject: [tests] add /threadz pages to PeriodicWebUIChecker
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Dec 2018 16:30:52 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] add /threadz pages to PeriodicWebUIChecker
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12114
to look at the new patch set (#3).
Change subject: [tests] add /threadz pages to PeriodicWebUIChecker
......................................................................
[tests] add /threadz pages to PeriodicWebUIChecker
With this patch, the PeriodicWebUIChecker periodically fetches
the /threadz and /threadz?group=all pages of the embedded Web server
along with other diagnostic pages. Also, shuffle the URLs that
are being check sequentially -- that adds more randomization in
the pattern of the requests sent by the checker.
In addition, this patch updates the webserver-stress-itest to
run more readers/writer threads for TestWorkload -- that allows
to expose more race conditions in TSAN/ASAN builds (and that
is used in a follow-up changelist).
Also, this patch contains other minor/non-functional updates.
Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
3 files changed, 58 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/12114/3
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] add /threadz pages to PeriodicWebUIChecker
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12114
to look at the new patch set (#2).
Change subject: [tests] add /threadz pages to PeriodicWebUIChecker
......................................................................
[tests] add /threadz pages to PeriodicWebUIChecker
With this patch, the PeriodicWebUIChecker periodically fetches
the /threadz and /threadz?group=all pages of the embedded Web server
along with other diagnostic pages. Also, shuffle the URLs that
are being check sequentially -- that adds more randomization in
the pattern of the requests sent by the checker.
In addition, this patch updates the webserver-stress-itest to
run more readers/writer threads for TestWorkload -- that allows
to expose more race conditions in TSAN/ASAN builds (and that
is used in a follow-up changelist).
Also, this patch contains other minor/non-functional updates.
Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
3 files changed, 50 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/12114/2
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] add /threadz page to PeriodicWebUIChecker
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12114 )
Change subject: [tests] add /threadz page to PeriodicWebUIChecker
......................................................................
Patch Set 1: Code-Review+2
Does this cause your next patch to trigger a TSAN data race in linked_list-test without that locking fix?
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:31:10 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] add /threadz pages to PeriodicWebUIChecker
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12114 )
Change subject: [tests] add /threadz pages to PeriodicWebUIChecker
......................................................................
[tests] add /threadz pages to PeriodicWebUIChecker
With this patch, the PeriodicWebUIChecker periodically fetches
the /threadz and /threadz?group=all pages of the embedded Web server
along with other diagnostic pages. Also, shuffle the URLs that
are being check sequentially -- that adds more randomization in
the pattern of the requests sent by the checker.
In addition, this patch updates the webserver-stress-itest to
run more readers/writer threads for TestWorkload -- that allows
to expose more race conditions in TSAN/ASAN builds (and that
is used in a follow-up changelist).
Also, this patch contains other minor/non-functional updates.
Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Reviewed-on: http://gerrit.cloudera.org:8080/12114
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
3 files changed, 58 insertions(+), 33 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] add /threadz page to PeriodicWebUIChecker
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12114 )
Change subject: [tests] add /threadz page to PeriodicWebUIChecker
......................................................................
Patch Set 1:
> Does this cause your next patch to trigger a TSAN data race in
> linked_list-test without that locking fix?
Thank you for fast review.
This didn't cause TSAN data race at the place where I expected it since the race would be exposed for /threads endpoint, not /threads?group=all (I realized it after posting this patch). I now updating the test to make sure TSAN shows some races.
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Dec 2018 01:53:15 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] add /threadz pages to PeriodicWebUIChecker
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12114 )
Change subject: [tests] add /threadz pages to PeriodicWebUIChecker
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12114/2/src/kudu/integration-tests/webserver-stress-itest.cc
File src/kudu/integration-tests/webserver-stress-itest.cc:
http://gerrit.cloudera.org:8080/#/c/12114/2/src/kudu/integration-tests/webserver-stress-itest.cc@79
PS2, Line 79: spawn
spawned
--
To view, visit http://gerrit.cloudera.org:8080/12114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6cbfe5108ac99231b82f662cee56ffcd25f026
Gerrit-Change-Number: 12114
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Dec 2018 05:16:58 +0000
Gerrit-HasComments: Yes