You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2014/02/09 20:59:34 UTC
Review Request 17880: Patch for KAFKA-1237
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17880/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1237
https://issues.apache.org/jira/browse/KAFKA-1237
Repository: kafka
Description
-------
Mirror maker with 08 consumer and 09 producer
Diffs
-----
build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f
Diff: https://reviews.apache.org/r/17880/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 17880: Patch for KAFKA-1237
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17880/#review34166
-----------------------------------------------------------
Ship it!
Ship It!
- Jay Kreps
On Feb. 9, 2014, 8:02 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17880/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 8:02 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1237
> https://issues.apache.org/jira/browse/KAFKA-1237
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Removed whitespace
>
>
> Mirror maker with 08 consumer and 09 producer
>
>
> Mirror maker with 08 consumer and 09 producer
>
>
> Diffs
> -----
>
> build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
> core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17880/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 17880: Patch for KAFKA-1237
Posted by Neha Narkhede <ne...@gmail.com>.
> On Feb. 10, 2014, 11:46 p.m., Guozhang Wang wrote:
> > build.gradle, line 139
> > <https://reviews.apache.org/r/17880/diff/3/?file=481186#file481186line139>
> >
> > If clients is included in compile do we still need to specify it in testCompile?
I don't think so but probably Jun can comment on that.
> On Feb. 10, 2014, 11:46 p.m., Guozhang Wang wrote:
> > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 41
> > <https://reviews.apache.org/r/17880/diff/3/?file=481187#file481187line41>
> >
> > Can you? This is a consumer config file right?
Fixed the doc. I removed the ability to take in multiple consumer configs on purpose. There isn't much advantage in using mirror maker that way vs just spinning up more instances of mirror maker, one per cluster. Also including multiple consumer configs also complicates troubleshooting
> On Feb. 10, 2014, 11:46 p.m., Guozhang Wang wrote:
> > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 175
> > <https://reviews.apache.org/r/17880/diff/3/?file=481187#file481187line175>
> >
> > producerIndex would better be AtomicInteger?
Good point.
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17880/#review34133
-----------------------------------------------------------
On Feb. 9, 2014, 8:02 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17880/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 8:02 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1237
> https://issues.apache.org/jira/browse/KAFKA-1237
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Removed whitespace
>
>
> Mirror maker with 08 consumer and 09 producer
>
>
> Mirror maker with 08 consumer and 09 producer
>
>
> Diffs
> -----
>
> build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
> core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17880/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 17880: Patch for KAFKA-1237
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17880/#review34133
-----------------------------------------------------------
Ship it!
Minor comments only.
build.gradle
<https://reviews.apache.org/r/17880/#comment64122>
If clients is included in compile do we still need to specify it in testCompile?
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala
<https://reviews.apache.org/r/17880/#comment64126>
Can you? This is a consumer config file right?
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala
<https://reviews.apache.org/r/17880/#comment64127>
Better change to "Embedded producer config file"
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala
<https://reviews.apache.org/r/17880/#comment64132>
producerIndex would better be AtomicInteger?
- Guozhang Wang
On Feb. 9, 2014, 8:02 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17880/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 8:02 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1237
> https://issues.apache.org/jira/browse/KAFKA-1237
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Removed whitespace
>
>
> Mirror maker with 08 consumer and 09 producer
>
>
> Mirror maker with 08 consumer and 09 producer
>
>
> Diffs
> -----
>
> build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
> core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17880/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 17880: Patch for KAFKA-1237
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17880/
-----------------------------------------------------------
(Updated Feb. 9, 2014, 8:02 p.m.)
Review request for kafka.
Bugs: KAFKA-1237
https://issues.apache.org/jira/browse/KAFKA-1237
Repository: kafka
Description (updated)
-------
Removed whitespace
Mirror maker with 08 consumer and 09 producer
Mirror maker with 08 consumer and 09 producer
Diffs (updated)
-----
build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala PRE-CREATION
Diff: https://reviews.apache.org/r/17880/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 17880: Patch for KAFKA-1237
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17880/
-----------------------------------------------------------
(Updated Feb. 9, 2014, 8:01 p.m.)
Review request for kafka.
Bugs: KAFKA-1237
https://issues.apache.org/jira/browse/KAFKA-1237
Repository: kafka
Description (updated)
-------
Mirror maker with 08 consumer and 09 producer
Mirror maker with 08 consumer and 09 producer
Diffs (updated)
-----
build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala PRE-CREATION
Diff: https://reviews.apache.org/r/17880/diff/
Testing
-------
Thanks,
Neha Narkhede