You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2016/04/07 13:29:58 UTC

[1/2] cloudstack-cloudmonkey git commit: Update requester.py

Repository: cloudstack-cloudmonkey
Updated Branches:
  refs/heads/master 305ce2963 -> 38b68fbe0


Update requester.py

urllib.quote_plus() requires the option safe="*" (that is, the * character is not encoded) to be consistent with CloudStack's internal encoder/decoder. Without this, API calls containing the * character will fail API authentication.

Project: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/commit/46b84a6e
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/tree/46b84a6e
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/diff/46b84a6e

Branch: refs/heads/master
Commit: 46b84a6ef713f939ce03b5e613d133ddbc70338f
Parents: 1035755
Author: Phillip Kent <ph...@xmlsoup.com>
Authored: Sat Dec 19 15:47:56 2015 +0000
Committer: Phillip Kent <ph...@xmlsoup.com>
Committed: Sat Dec 19 15:47:56 2015 +0000

----------------------------------------------------------------------
 cloudmonkey/requester.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/46b84a6e/cloudmonkey/requester.py
----------------------------------------------------------------------
diff --git a/cloudmonkey/requester.py b/cloudmonkey/requester.py
index cf082aa..f8c038d 100644
--- a/cloudmonkey/requester.py
+++ b/cloudmonkey/requester.py
@@ -202,7 +202,7 @@ def make_request(command, args, logger, url, credentials, expires,
         hash_str = "&".join(
             ["=".join(
                 [r[0].lower(),
-                 urllib.quote_plus(str(r[1])).lower()
+                 urllib.quote_plus(str(r[1]), safe="*").lower()
                  .replace("+", "%20").replace("%3A", ":")]
             ) for r in request]
         )


[2/2] cloudstack-cloudmonkey git commit: Merge pull request #11 from phillipkent/fix_urllib_quote_plus

Posted by bh...@apache.org.
Merge pull request #11 from phillipkent/fix_urllib_quote_plus

Update requester.pyurllib.quote_plus() requires the option safe="*" (that is, the * character is not encoded) to be consistent with CloudStack's internal encoder/decoder. Without this, API calls containing the * character will fail API authentication.

* pr/11:
  Update requester.py

Signed-off-by: Rohit Yadav <ro...@shapeblue.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/commit/38b68fbe
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/tree/38b68fbe
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/diff/38b68fbe

Branch: refs/heads/master
Commit: 38b68fbe0bf9a4bea1836bba55be57928ef74cee
Parents: 305ce29 46b84a6
Author: Rohit Yadav <ro...@shapeblue.com>
Authored: Thu Apr 7 16:59:12 2016 +0530
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Thu Apr 7 16:59:12 2016 +0530

----------------------------------------------------------------------
 cloudmonkey/requester.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/38b68fbe/cloudmonkey/requester.py
----------------------------------------------------------------------