You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "loosebazooka (via GitHub)" <gi...@apache.org> on 2024/07/24 18:56:49 UTC

[PR] [MGPG-130] - Update sigstore extension for exclusion [maven-gpg-plugin]

loosebazooka opened a new pull request, #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109

   Sigstore uses ".sigstore.json" extension in all our plugins, ".sigstore" is no longer used
   
   Following this checklist to help us incorporate your contribution quickly and easily:
   
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MGPG) filed for the change (usually
     before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should
     address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Format the pull request title like `[MGPG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MGPG-XXX`
     with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the
     first line of the commit message.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull
     request automatically.
   - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the
   developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [ ] I hereby declare this contribution to be licenced under
     the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file
     an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109#issuecomment-2248836197

   I would leave old and add sigstore.json as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "loosebazooka (via GitHub)" <gi...@apache.org>.
loosebazooka commented on PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109#issuecomment-2251092098

   > I would leave old and add sigstore.json as well
   
   That works, we just don't intend on making any new signatures using that extension. But I have no strong preference.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "loosebazooka (via GitHub)" <gi...@apache.org>.
loosebazooka commented on PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109#issuecomment-2253184508

   @cstamas updated to re-include ".sigstore". I added a tracker to remove it in 6 months or so (https://github.com/sigstore/sigstore-java/issues/759)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "loosebazooka (via GitHub)" <gi...@apache.org>.
loosebazooka commented on PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109#issuecomment-2276027510

   @cstamas any chance this could get another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "loosebazooka (via GitHub)" <gi...@apache.org>.
loosebazooka commented on PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109#issuecomment-2254277922

   This windows test just timing out?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109#issuecomment-2251189888

   Are any of the two maven sigstore plugins alive? Afair, they used ".sigstore" for extension...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MGPG-130] - Update sigstore extension to ".sigstore.json" [maven-gpg-plugin]

Posted by "loosebazooka (via GitHub)" <gi...@apache.org>.
loosebazooka commented on PR #109:
URL: https://github.com/apache/maven-gpg-plugin/pull/109#issuecomment-2253166092

   Both standalone plugin repositories are archived ([1](https://github.com/sigstore/sigstore-maven), [2](https://github.com/sigstore/sigstore-maven-plugin)), things were a little wild west at the beginning :shrug: . The "supported" plugin is integrated into the sigstore-java repository at https://github.com/sigstore/sigstore-java/tree/main/sigstore-maven-plugin. <-- this supersedes the code in https://github.com/sigstore/sigstore-maven-plugin (which is archived). The latest release at https://central.sonatype.com/artifact/dev.sigstore/sigstore-maven-plugin/0.11.0/versions 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org