You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2023/07/14 23:05:00 UTC

[jira] [Comment Edited] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40

    [ https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743254#comment-17743254 ] 

Michael Semb Wever edited comment on CASSANDRA-18314 at 7/14/23 11:04 PM:
--------------------------------------------------------------------------

The patch deprecates VERSION_30 and VERSION_3014, removes serialisation with those versions from Mutation and CounterMutation, removes handshake and connection code related to 30 and 3014, and adds the method supportedVersions() to list MS versions from minimum_version up.

Is HintsDescriptor.VERSION_30 still needed?

CI
https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/181

ConnectionTest and ProxyHandlerConnectionTest are already known to be flakies (CASSANDRA-16677 , CASSANDRA-18641 , CASSANDRA-18257).


was (Author: michaelsembwever):
CI
https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/181

ConnectionTest and ProxyHandlerConnectionTest are already known to be flakies (CASSANDRA-16677 , CASSANDRA-18641 , CASSANDRA-18257).

> Lift MessagingService.minimum_version to 40
> -------------------------------------------
>
>                 Key: CASSANDRA-18314
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18314
>             Project: Cassandra
>          Issue Type: Task
>          Components: Messaging/Internode
>            Reporter: Michael Semb Wever
>            Assignee: Michael Semb Wever
>            Priority: Normal
>             Fix For: 5.x
>
>
> MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in Cassandra 5.0 anymore.
> (Cassandra 5.0 currently is still using VERSION_40)
> Patch: https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk
> Raises the question whether backward compatibility to the previous major is defined by the Cassandra version or by the internal component version (MessagingService).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org