You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/02 22:51:08 UTC
[GitHub] eric-haibin-lin commented on a change in pull request #12749:
[MXNET-1029] Feature request: randint operator
eric-haibin-lin commented on a change in pull request #12749: [MXNET-1029] Feature request: randint operator
URL: https://github.com/apache/incubator-mxnet/pull/12749#discussion_r230528304
##########
File path: include/mxnet/random_generator.h
##########
@@ -71,14 +71,23 @@ class RandGenerator<cpu, DType> {
return dist_uniform(*engine_);
}
+ MSHADOW_XINLINE int discrete_uniform(const int lower, const int upper) {
Review comment:
Does it only support int32? Does the test case pass if you have randint with range 4B to 4B + 10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services