You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/24 10:46:54 UTC
[GitHub] [netbeans] dbalek opened a new pull request #3123: LSP: Move refactoring added.
dbalek opened a new pull request #3123:
URL: https://github.com/apache/netbeans/pull/3123
- Move refactoring added
- CodeActions rewitten to Parsing API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a change in pull request #3123: LSP: Move refactoring added.
Posted by GitBox <gi...@apache.org>.
dbalek commented on a change in pull request #3123:
URL: https://github.com/apache/netbeans/pull/3123#discussion_r696018841
##########
File path: ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java
##########
@@ -80,7 +80,7 @@ public Problem checkParameters() {
public void cancelRequest() {
}
- private class MoveFile extends SimpleRefactoringElementImplementation {
+ public class MoveFile extends SimpleRefactoringElementImplementation {
Review comment:
Is the API change note really necessary for a class in a NON public package? It is used in an `instanceof` check inside `MoveRefactoring.move(...)` method. However, the `instancof` could be avoided if you insist on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #3123: LSP: Move refactoring added.
Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #3123:
URL: https://github.com/apache/netbeans/pull/3123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3123: LSP: Move refactoring added.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3123:
URL: https://github.com/apache/netbeans/pull/3123#discussion_r695722532
##########
File path: ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java
##########
@@ -80,7 +80,7 @@ public Problem checkParameters() {
public void cancelRequest() {
}
- private class MoveFile extends SimpleRefactoringElementImplementation {
+ public class MoveFile extends SimpleRefactoringElementImplementation {
Review comment:
Is this new API class supposed to be subclassable? As it seems it is...
##########
File path: ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java
##########
@@ -80,7 +80,7 @@ public Problem checkParameters() {
public void cancelRequest() {
}
- private class MoveFile extends SimpleRefactoringElementImplementation {
+ public class MoveFile extends SimpleRefactoringElementImplementation {
Review comment:
There should be an API change note, I assume. Btw. is everything referenced - e.g. `SimpleRefactoringElementImplementation`, `RefactoringElementsBag` already public? Btw. I don't see a reason why this class was made public - searching for `MoveFile` yields no results...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3123: LSP: Move refactoring added.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3123:
URL: https://github.com/apache/netbeans/pull/3123#discussion_r696357101
##########
File path: ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java
##########
@@ -80,7 +80,7 @@ public Problem checkParameters() {
public void cancelRequest() {
}
- private class MoveFile extends SimpleRefactoringElementImplementation {
+ public class MoveFile extends SimpleRefactoringElementImplementation {
Review comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists