You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Nicolaas Matthijs (JIRA)" <ji...@apache.org> on 2008/07/22 11:42:31 UTC
[jira] Created: (SHINDIG-465) Samplecontainer Javascript
Improvement
Samplecontainer Javascript Improvement
--------------------------------------
Key: SHINDIG-465
URL: https://issues.apache.org/jira/browse/SHINDIG-465
Project: Shindig
Issue Type: Improvement
Components: Sample container & Examples
Reporter: Nicolaas Matthijs
I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-465) Samplecontainer Javascript
Improvement
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll resolved SHINDIG-465.
---------------------------------
Resolution: Fixed
Assignee: Cassie Doll
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Assignee: Cassie Doll
> Attachments: samplecontainer-javascript-improvements-003.patch.txt
>
>
> I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-465) Samplecontainer Javascript
Improvement
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-465:
--------------------------------------
Attachment: samplecontainer-javascript-improvements-003.patch.txt
Adjusted the patch so that it works with "patch -p0" in stead of "patch -p1". Tested this on a clean svn checkout and seems to be working.
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: samplecontainer-javascript-improvements-003.patch.txt
>
>
> I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-465) Samplecontainer Javascript
Improvement
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-465:
--------------------------------------
Attachment: improvement-samplecontainer-javascript.patch
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: improvement-samplecontainer-javascript.patch
>
>
> I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-465) Samplecontainer Javascript
Improvement
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-465:
--------------------------------------
Attachment: (was: samplecontainer-javascript-improvements-002.patch)
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: samplecontainer-javascript-improvements-003.patch.txt
>
>
> I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-465) Samplecontainer Javascript
Improvement
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-465:
--------------------------------------
Attachment: samplecontainer-javascript-improvements-002.patch
Removed some wrong line-endings, removed the tabs and replaced it by 2 spaces and removed some trailing spaces
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: samplecontainer-javascript-improvements-002.patch
>
>
> I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-465) Samplecontainer Javascript
Improvement
Posted by "Nicolaas Matthijs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolaas Matthijs updated SHINDIG-465:
--------------------------------------
Attachment: (was: improvement-samplecontainer-javascript.patch)
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
>
> I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-465) Samplecontainer Javascript
Improvement
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616917#action_12616917 ]
Cassie Doll commented on SHINDIG-465:
-------------------------------------
I think these changes will be great but I can't use the patch that you attached because its format is off. If you could do the following:
cd <your shindig root>
svn diff > samplecontainer-javascript-improvements-003.patch
and attach that new patch to this bug then i should be able to patch it into my client.
Thanks!
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: samplecontainer-javascript-improvements-002.patch
>
>
> I've removed the javascript from the samplecontainer.html file and put it into a javascript file. I've also slightly adjusted the javascript code to comply with the current javascript best practices. I've put everything into a general shindig namespace, with a samplecontainer subnamespace. Then I've put all the javascript code into a closure to stop it from polluting the global namespace. Only the functions that needed to be visible outside of this javascript scope have been put public inside the shindig namespace, everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.