You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/02/28 09:16:30 UTC
Review Request 74328: RANGER-4089: Getting browser specific pop-up message if try to delete policy after edit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74328/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4089
https://issues.apache.org/jira/browse/RANGER-4089
Repository: ranger
Description
-------
Getting browser specific pop-up message if try to delete policy after edit
Steps to reproduce :
1. Create a policy
2. Edit policy , instead of save click on delete , user is getting browser specic pop-up .
3. If move to different tab Policy is deleted & user will be present on Deleted policy edit page .
Expected : Behaviour should be like old UI , Once system specific Delete confirmation popup should be enough.
Thanks
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 876afd4f9
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx 6895898bd
Diff: https://reviews.apache.org/r/74328/diff/1/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
- CRUD operation on Policy Forms.
- Deleting policy while editing it.
- Policy listing tables.
Thanks,
Brijesh Bhalala
Re: Review Request 74328: RANGER-4089: Getting browser specific pop-up message if try to delete policy after edit
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74328/#review225253
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Feb. 28, 2023, 9:16 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74328/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2023, 9:16 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4089
> https://issues.apache.org/jira/browse/RANGER-4089
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Getting browser specific pop-up message if try to delete policy after edit
>
> Steps to reproduce :
> 1. Create a policy
> 2. Edit policy , instead of save click on delete , user is getting browser specic pop-up .
> 3. If move to different tab Policy is deleted & user will be present on Deleted policy edit page .
>
> Expected : Behaviour should be like old UI , Once system specific Delete confirmation popup should be enough.
>
> Thanks
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 876afd4f9
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx 6895898bd
>
>
> Diff: https://reviews.apache.org/r/74328/diff/1/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> - CRUD operation on Policy Forms.
> - Deleting policy while editing it.
> - Policy listing tables.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74328: RANGER-4089: Getting browser specific pop-up message if try to delete policy after edit
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74328/#review225252
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On Feb. 28, 2023, 9:16 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74328/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2023, 9:16 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4089
> https://issues.apache.org/jira/browse/RANGER-4089
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Getting browser specific pop-up message if try to delete policy after edit
>
> Steps to reproduce :
> 1. Create a policy
> 2. Edit policy , instead of save click on delete , user is getting browser specic pop-up .
> 3. If move to different tab Policy is deleted & user will be present on Deleted policy edit page .
>
> Expected : Behaviour should be like old UI , Once system specific Delete confirmation popup should be enough.
>
> Thanks
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 876afd4f9
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx 6895898bd
>
>
> Diff: https://reviews.apache.org/r/74328/diff/1/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> - CRUD operation on Policy Forms.
> - Deleting policy while editing it.
> - Policy listing tables.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>