You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2017/01/27 11:34:13 UTC
[GitHub] flink pull request #3225: [FLINK-5670] Properly clean up local RocksDB direc...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3225
[FLINK-5670] Properly clean up local RocksDB directories
We have to change the instance path to not include too many nested
directories, otherwise the Keyed backend cannot properly clean up the
whole directory hierachy.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink fix-rocksdb-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3225
----
commit 8d0b3ed5437ddb09f4cef376d8d7433b7b4e27b6
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2017-01-27T11:32:21Z
[FLINK-5670] Properly clean up local RocksDB directories
We have to change the instance path to not include too many nested
directories, otherwise the Keyed backend cannot properly clean up the
whole directory hierachy.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3225: [FLINK-5670] Properly clean up local RocksDB directories
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3225
Thanks \U0001f44d \U0001f603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3225: [FLINK-5670] Properly clean up local RocksDB directories
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3225
@uce are you checking this with the Job where you initially discovered it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3225: [FLINK-5670] Properly clean up local RocksDB direc...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3225: [FLINK-5670] Properly clean up local RocksDB directories
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3225
@uce, @StefanRRichter Could you please have a look, I think it would be good to have that in Flink 1.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3225: [FLINK-5670] Properly clean up local RocksDB directories
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3225
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3225: [FLINK-5670] Properly clean up local RocksDB directories
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3225
Just verified it with the job. Works fine now! All directories were cleaned up properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---