You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2011/04/08 18:24:05 UTC

[jira] [Created] (MAHOUT-661) Finish iterator overhaul by using Google Guava

Finish iterator overhaul by using Google Guava
----------------------------------------------

                 Key: MAHOUT-661
                 URL: https://issues.apache.org/jira/browse/MAHOUT-661
             Project: Mahout
          Issue Type: Improvement
          Components: Classification, Clustering, Collaborative Filtering, Frequent Itemset/Association Rule Mining, Utils
    Affects Versions: 0.4
            Reporter: Sean Owen
            Assignee: Sean Owen
            Priority: Minor
             Fix For: 0.5


To complete this truly interesting overhaul of the use of Iterator -- I rightly guessed that Guava already has some of these common classes and more. Indeed. I can see easily another 1,000 lines of code of savings by adapting to use their iterator primitives. I'm in progress now and have removed 600 lines so far. I think this will go a long way to avoiding subtle and various bugs in the iterator implementations to date. I can definitley get it in before 0.5.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAHOUT-661) Finish iterator overhaul by using Google Guava

Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated MAHOUT-661:
-----------------------------

    Attachment: MAHOUT-661.patch

Nicely, it removes a net 1100 lines of code.
This also uses Charsets.UTF_8 as a bonus.

> Finish iterator overhaul by using Google Guava
> ----------------------------------------------
>
>                 Key: MAHOUT-661
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-661
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification, Clustering, Collaborative Filtering, Frequent Itemset/Association Rule Mining, Utils
>    Affects Versions: 0.4
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: guava, iterable, iterator
>             Fix For: 0.5
>
>         Attachments: MAHOUT-661.patch
>
>
> To complete this truly interesting overhaul of the use of Iterator -- I rightly guessed that Guava already has some of these common classes and more. Indeed. I can see easily another 1,000 lines of code of savings by adapting to use their iterator primitives. I'm in progress now and have removed 600 lines so far. I think this will go a long way to avoiding subtle and various bugs in the iterator implementations to date. I can definitley get it in before 0.5.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAHOUT-661) Finish iterator overhaul by using Google Guava

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018146#comment-13018146 ] 

Hudson commented on MAHOUT-661:
-------------------------------

Integrated in Mahout-Quality #736 (See [https://hudson.apache.org/hudson/job/Mahout-Quality/736/])
    MAHOUT-661 move to Guava iterators and charsets


> Finish iterator overhaul by using Google Guava
> ----------------------------------------------
>
>                 Key: MAHOUT-661
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-661
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification, Clustering, Collaborative Filtering, Frequent Itemset/Association Rule Mining, Utils
>    Affects Versions: 0.4
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: guava, iterable, iterator
>             Fix For: 0.5
>
>         Attachments: MAHOUT-661.patch
>
>
> To complete this truly interesting overhaul of the use of Iterator -- I rightly guessed that Guava already has some of these common classes and more. Indeed. I can see easily another 1,000 lines of code of savings by adapting to use their iterator primitives. I'm in progress now and have removed 600 lines so far. I think this will go a long way to avoiding subtle and various bugs in the iterator implementations to date. I can definitley get it in before 0.5.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAHOUT-661) Finish iterator overhaul by using Google Guava

Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated MAHOUT-661:
-----------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

> Finish iterator overhaul by using Google Guava
> ----------------------------------------------
>
>                 Key: MAHOUT-661
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-661
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification, Clustering, Collaborative Filtering, Frequent Itemset/Association Rule Mining, Utils
>    Affects Versions: 0.4
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: guava, iterable, iterator
>             Fix For: 0.5
>
>         Attachments: MAHOUT-661.patch
>
>
> To complete this truly interesting overhaul of the use of Iterator -- I rightly guessed that Guava already has some of these common classes and more. Indeed. I can see easily another 1,000 lines of code of savings by adapting to use their iterator primitives. I'm in progress now and have removed 600 lines so far. I think this will go a long way to avoiding subtle and various bugs in the iterator implementations to date. I can definitley get it in before 0.5.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAHOUT-661) Finish iterator overhaul by using Google Guava

Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated MAHOUT-661:
-----------------------------

    Status: Patch Available  (was: Open)

> Finish iterator overhaul by using Google Guava
> ----------------------------------------------
>
>                 Key: MAHOUT-661
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-661
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification, Clustering, Collaborative Filtering, Frequent Itemset/Association Rule Mining, Utils
>    Affects Versions: 0.4
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: guava, iterable, iterator
>             Fix For: 0.5
>
>
> To complete this truly interesting overhaul of the use of Iterator -- I rightly guessed that Guava already has some of these common classes and more. Indeed. I can see easily another 1,000 lines of code of savings by adapting to use their iterator primitives. I'm in progress now and have removed 600 lines so far. I think this will go a long way to avoiding subtle and various bugs in the iterator implementations to date. I can definitley get it in before 0.5.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira