You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kezhenxu94 (GitHub)" <gi...@apache.org> on 2019/01/23 12:18:23 UTC
[GitHub] [incubator-dubbo-ops] kezhenxu94 opened pull request #277:
test service's parameterized methods
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] sunbufu commented on pull request
#277: test service's parameterized methods
Posted by "sunbufu (GitHub)" <gi...@apache.org>.
Good job, Thx.
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #277:
test service's parameterized methods
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=h1) Report
> Merging [#277](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=desc) into [service-test](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/936396cadaa82c0cadf1dfaa87f22d8d5823cbfd?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## service-test #277 +/- ##
==================================================
+ Coverage 12.2% 12.27% +0.07%
Complexity 177 177
==================================================
Files 91 91
Lines 3646 3649 +3
Branches 571 571
==================================================
+ Hits 445 448 +3
Misses 3162 3162
Partials 39 39
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/dubbo/admin/model/domain/MethodMetadata.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL01ldGhvZE1ldGFkYXRhLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...stry/metadata/impl/ZookeeperMetaDataCollector.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vcmVnaXN0cnkvbWV0YWRhdGEvaW1wbC9ab29rZWVwZXJNZXRhRGF0YUNvbGxlY3Rvci5qYXZh) | `40% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/admin/common/util/ServiceTestUtil.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvU2VydmljZVRlc3RVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/controller/ServiceTestController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlVGVzdENvbnRyb2xsZXIuamF2YQ==) | `18.18% <100%> (+12.91%)` | `1 <1> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=footer). Last update [936396c...7b9e5de](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request
#277: test service's parameterized methods
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
Because the values of the returned types are not identical and using generic type in collection is considered a good practice
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] sunbufu commented on pull request
#277: test service's parameterized methods
Posted by "sunbufu (GitHub)" <gi...@apache.org>.
Hi, can you tell me why use `List<Object>` ?
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] sunbufu commented on pull request
#277: test service's parameterized methods
Posted by "sunbufu (GitHub)" <gi...@apache.org>.
I don't know where is `List<Object>` is better than `List`.
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #277:
test service's parameterized methods
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=h1) Report
> Merging [#277](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=desc) into [service-test](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/936396cadaa82c0cadf1dfaa87f22d8d5823cbfd?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## service-test #277 +/- ##
==================================================
+ Coverage 12.2% 12.27% +0.07%
Complexity 177 177
==================================================
Files 91 91
Lines 3646 3649 +3
Branches 571 571
==================================================
+ Hits 445 448 +3
Misses 3162 3162
Partials 39 39
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/dubbo/admin/model/domain/MethodMetadata.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL01ldGhvZE1ldGFkYXRhLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...stry/metadata/impl/ZookeeperMetaDataCollector.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vcmVnaXN0cnkvbWV0YWRhdGEvaW1wbC9ab29rZWVwZXJNZXRhRGF0YUNvbGxlY3Rvci5qYXZh) | `40% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/admin/common/util/ServiceTestUtil.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvU2VydmljZVRlc3RVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/controller/ServiceTestController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlVGVzdENvbnRyb2xsZXIuamF2YQ==) | `18.18% <100%> (+12.91%)` | `1 <1> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=footer). Last update [936396c...7b9e5de](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/277?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #277:
test service's parameterized methods
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on pull request
#277: test service's parameterized methods
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
It will suppress the compile warning if I must give a reason, and it is considered a better practice in new code, see more discussion in [this thread](https://stackoverflow.com/a/2770692/5200161).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/277 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org