You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/08 21:12:44 UTC

[GitHub] [tvm] masahi commented on pull request #7611: [TOPI][GPU] Mergepath sort with odd-even block sort

masahi commented on pull request #7611:
URL: https://github.com/apache/tvm/pull/7611#issuecomment-793081245


   @mbrookhart This doesn't work on VK/SPIR-V because they SPIR-V requires a thread block size to be a compile time constant, see https://github.com/apache/tvm/blob/d7f57532746680732e58ab028d8c3129b9140d3d/src/target/spirv/codegen_spirv.cc#L106
   
   In particular, the following size selection has an issue, because `width` is not a constant:
   https://github.com/apache/tvm/blob/d2940ca8e25aa400825b79ac7d03da0ff4543db2/python/tvm/topi/cuda/sort.py#L335-L337
   
   So to workaround this problem, can we either
   * Use old TIR sort for VK
   * (Better) Use a constant thread block size for VK
   ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org