[jira] [Commented] (MESOS-4862) Setting failover_timeout in FrameworkInfo to Double.MAX_VALUE causes it to be set to zero

["Timothy Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179057#comment-15179057 ] 

Timothy Chen commented on MESOS-4862:
-------------------------------------

I think we should make framework timeout int64 instead of a double, I don't think we really need that much precision for failover timeout, and the cost of doing so causes problem like this.

> Setting failover_timeout in FrameworkInfo to Double.MAX_VALUE causes it to be set to zero
> -----------------------------------------------------------------------------------------
>
>                 Key: MESOS-4862
>                 URL: https://issues.apache.org/jira/browse/MESOS-4862
>             Project: Mesos
>          Issue Type: Bug
>          Components: master, stout
>            Reporter: Timothy Chen
>
> Currently we expose framework failover_timeout as a double in Proto, and if users set the failover_timeout to Double.MAX_VALUE, the Master will actually set it to zero which is the complete opposite of the original intent.
> The problem is that in stout/duration.hpp we only store down to the nanoseconds with int64_t, and it gives an error when we pass double.max as it goes out of the int64_t bounds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)