You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/10/22 08:05:31 UTC
[PR] test(runtime-host): publish crash readiness atomically [maka]
Astro-Han opened a new pull request, #6236:
URL: https://github.com/apache/maka/pull/6236
## Summary
The ShellRun crash fixture exposes `ready.json` as soon as `writeFile` opens it. The parent can read it before the JSON is complete, failing the recovery test with `Unexpected end of JSON input`, as in [main CI](https://github.com/apache/maka/actions/runs/39730038122).
Write the marker to a temporary sibling and rename it after the write finishes. The parent sees either no marker or the complete payload. This changes test coordination only.
## Verification
- Built core, storage, runtime and runtime-host; formatting, lint and `git diff --check` passed.
- Both existing ShellRun crash recovery cases passed through the real child-process fixture.
- The complete goal-root-authority file ran 65 tests: 63 passed, one fixture skipped, and the separate background Bash `stop` case failed because its `starts` file did not exist. The marker change does not touch that case. Full workspace tests and Linux execution are left to CI.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex diagnosed the fixture publication race, changed the marker write, ran the checks and prepared this PR.
## Checklist
- [ ] Tests cover the change and fail without it
- [ ] Lint, format, typecheck and the affected suites pass locally
The original failure was observed in CI; existing crash recovery tests were reused. The local checks above describe the separate failure.
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] chore(release): prepare 0.2.2 RC2 notes, fixtures and dependencies [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6236:
URL: https://github.com/apache/maka/pull/6236#discussion_r4365450885
##########
package-lock.json:
##########
@@ -17619,9 +17619,9 @@
}
},
"packages/runtime/node_modules/undici": {
- "version": "8.11.2",
- "resolved": "https://registry.npmjs.org/undici/-/undici-8.11.2.tgz",
- "integrity": "sha512-u4UB2/IrKdU6lFxumHmmo1a3fCQO5tzQllRorfoRS63txhrB7xTpSn1PftwC4qEHkOaqP95fCWW4lJzwErwzhQ==",
+ "version": "8.12.3",
Review Comment:
[P2] Synchronize the CLI packager with the Undici version bump
This removes the 8.11.2 instance from the installed CLI dependency tree, but `scripts/release-cli-package.mjs` still calls `findDependency(cli, 'undici', '8.11.2')` at both lines 374 and 670. The current-head **Build immutable tarball** job fails at the first lookup with `The installed CLI closure does not contain undici@8.11.2`, so the installed-CLI validation jobs cannot run. I reproduced the failure using this head's real installed CLI tree and the actual dependency-selection functions; selecting 8.12.3 instead completes that stage. Update both the closure-copy and release-manifest selection to the supported installed version and rerun the tarball validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] chore(release): prepare 0.2.2 RC2 notes, fixtures and dependencies [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6236:
URL: https://github.com/apache/maka/pull/6236#discussion_r4365633341
##########
scripts/release-cli-package.mjs:
##########
@@ -53,6 +54,9 @@ import {
const repoRoot = resolve(import.meta.dirname, '..');
const cliSource = join(repoRoot, 'packages/cli');
+const evalUndiciVersion = createRequire(join(repoRoot, 'packages/eval/package.json'))(
Review Comment:
[P2] Resolve the installed Eval dependency after bootstrapping
This top-level require executes before `main()` can call `buildFromCleanDependencyTree()` and run its isolated `npm ci`. The immutable-tarball job in `.github/workflows/cli-package-validation.yml` starts from a fresh checkout, selects npm globally, and then runs `release:cli:pack` without installing root dependencies first. Consequently the new entry point throws `Cannot find module 'undici/package.json'` before its own installer can run. Current-head job 120743894587 and an unmodified dependency-free source-archive reproduction both fail here; the prior entry point reaches the installer boundary. Defer resolving the installed Eval version until the prepared tree has dependencies, while keeping both closure-copy and manifest lookups synchronized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] chore(release): prepare 0.2.2 RC2 notes, fixtures and dependencies [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6236:
URL: https://github.com/apache/maka/pull/6236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org