You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "MasterJH5574 (via GitHub)" <gi...@apache.org> on 2023/07/06 00:09:58 UTC

[GitHub] [tvm] MasterJH5574 opened a new pull request, #15251: [TIR] Blockize keeping T.init in inner block when outer block does no reduction

MasterJH5574 opened a new pull request, #15251:
URL: https://github.com/apache/tvm/pull/15251

   This PR enhances the behavior of tir.Schedule.blockize, so that when the outer block after blockization does no effective reduction, the `T.init` part will be kept in the inner block.
   
   No new unit test is added as the update of the existing tests in this PR has already covered the correctness and ensured the expected behavior.
   
   Co-authored-by: Bohan Hou <sp...@gmail.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15251: [TIR] Blockize keeping T.init in inner block when outer block does no reduction

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15251:
URL: https://github.com/apache/tvm/pull/15251#issuecomment-1622714482

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] MasterJH5574 commented on pull request #15251: [TIR] Blockize keeping T.init in inner block when outer block does no reduction

Posted by "MasterJH5574 (via GitHub)" <gi...@apache.org>.
MasterJH5574 commented on PR #15251:
URL: https://github.com/apache/tvm/pull/15251#issuecomment-1622714892

   Depending on #15251.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] MasterJH5574 closed pull request #15251: [TIR] Blockize keeping T.init in inner block when outer block does no reduction

Posted by "MasterJH5574 (via GitHub)" <gi...@apache.org>.
MasterJH5574 closed pull request #15251: [TIR] Blockize keeping T.init in inner block when outer block does no reduction
URL: https://github.com/apache/tvm/pull/15251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] MasterJH5574 commented on pull request #15251: [TIR] Blockize keeping T.init in inner block when outer block does no reduction

Posted by "MasterJH5574 (via GitHub)" <gi...@apache.org>.
MasterJH5574 commented on PR #15251:
URL: https://github.com/apache/tvm/pull/15251#issuecomment-1637027498

   Closed since the intention of this PR seems to break MS tuning which is more complicated for fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] yzh119 commented on a diff in pull request #15251: [TIR] Blockize keeping T.init in inner block when outer block does no reduction

Posted by "yzh119 (via GitHub)" <gi...@apache.org>.
yzh119 commented on code in PR #15251:
URL: https://github.com/apache/tvm/pull/15251#discussion_r1254124378


##########
tests/python/unittest/test_tir_schedule_blockize.py:
##########
@@ -355,4 +353,5 @@ def after_blocks_blockize(
 
 
 if __name__ == "__main__":
-    tvm.testing.main()
+    test_blockize_outer()

Review Comment:
   Keep it `tvm.testing.main()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org