You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Biubiubiu12 (via GitHub)" <gi...@apache.org> on 2023/03/15 08:30:27 UTC
[GitHub] [tvm] Biubiubiu12 opened a new pull request, #14304: [Bugfix][TensorIR] Fix tvm::arith::UnionLowerBound
Biubiubiu12 opened a new pull request, #14304:
URL: https://github.com/apache/tvm/pull/14304
The UnionLowerBound function does not take into account the condition that the empty set has a special representation [+inf, -inf].
cc@wrongtest-intellif
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on a diff in pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "wrongtest-intellif (via GitHub)" <gi...@apache.org>.
wrongtest-intellif commented on code in PR #14304:
URL: https://github.com/apache/tvm/pull/14304#discussion_r1136970296
##########
tests/python/unittest/test_arith_intset.py:
##########
@@ -370,7 +370,8 @@ def test_union_lower_bound():
pos_inf = tvm.arith.int_set.pos_inf()
set_0 = tvm.arith.IntervalSet(min_value=neg_inf, max_value=0)
set_1 = tvm.arith.IntervalSet(min_value=1, max_value=pos_inf)
- result = tvm.arith.int_set.union_lower_bound([set_0, set_1])
+ set_2 = tvm.arith.IntervalSet(min_value=pos_inf, max_value=neg_inf)
+ result = tvm.arith.int_set.union_lower_bound([set_0, set_1, set_2])
Review Comment:
it is better to preserve original case and just append new cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 commented on pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1473464289
> Please make the CI green and we can get it in :-)
Hi, CI is finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on a diff in pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "wrongtest-intellif (via GitHub)" <gi...@apache.org>.
wrongtest-intellif commented on code in PR #14304:
URL: https://github.com/apache/tvm/pull/14304#discussion_r1138009921
##########
tests/python/unittest/test_arith_intset.py:
##########
@@ -373,6 +373,8 @@ def test_union_lower_bound():
result = tvm.arith.int_set.union_lower_bound([set_0, set_1])
assert result.min_value.same_as(neg_inf)
assert result.max_value.same_as(pos_inf)
+ set_2 = tvm.arith.IntervalSet(min_value=pos_inf, max_value=neg_inf)
+ result = tvm.arith.int_set.union_lower_bound([set_0, set_2])
Review Comment:
missing final result assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 commented on pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1469835293
> Could you please add a regression test?
Already added, thanks for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 closed pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 closed pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
URL: https://github.com/apache/tvm/pull/14304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest-intellif commented on pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "wrongtest-intellif (via GitHub)" <gi...@apache.org>.
wrongtest-intellif commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1469668242
We could add a testcase to tests/python/unittest/test_arith_intset.py::test_union_lower_bound
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 commented on a diff in pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 commented on code in PR #14304:
URL: https://github.com/apache/tvm/pull/14304#discussion_r1138007524
##########
tests/python/unittest/test_arith_intset.py:
##########
@@ -370,7 +370,8 @@ def test_union_lower_bound():
pos_inf = tvm.arith.int_set.pos_inf()
set_0 = tvm.arith.IntervalSet(min_value=neg_inf, max_value=0)
set_1 = tvm.arith.IntervalSet(min_value=1, max_value=pos_inf)
- result = tvm.arith.int_set.union_lower_bound([set_0, set_1])
+ set_2 = tvm.arith.IntervalSet(min_value=pos_inf, max_value=neg_inf)
+ result = tvm.arith.int_set.union_lower_bound([set_0, set_1, set_2])
Review Comment:
code updated，thanks for your great advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14304: [Bugfix][TensorIR] Fix tvm::arith::UnionLowerBound
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1469565433
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `bugfix`, `tensorir` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1469632343
Could you please add a regression test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 commented on pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1472997741
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #14304:
URL: https://github.com/apache/tvm/pull/14304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 commented on pull request #14304: [Bugfix][TensorIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1469566529
cc @wrongtest-intellif
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 commented on pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 commented on PR #14304:
URL: https://github.com/apache/tvm/pull/14304#issuecomment-1469836695
> We could add a testcase to tests/python/unittest/test_arith_intset.py::test_union_lower_bound
Already added, thanks for your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Biubiubiu12 commented on a diff in pull request #14304: [Fix][TIR] Fix tvm::arith::UnionLowerBound
Posted by "Biubiubiu12 (via GitHub)" <gi...@apache.org>.
Biubiubiu12 commented on code in PR #14304:
URL: https://github.com/apache/tvm/pull/14304#discussion_r1138029645
##########
tests/python/unittest/test_arith_intset.py:
##########
@@ -373,6 +373,8 @@ def test_union_lower_bound():
result = tvm.arith.int_set.union_lower_bound([set_0, set_1])
assert result.min_value.same_as(neg_inf)
assert result.max_value.same_as(pos_inf)
+ set_2 = tvm.arith.IntervalSet(min_value=pos_inf, max_value=neg_inf)
+ result = tvm.arith.int_set.union_lower_bound([set_0, set_2])
Review Comment:
code updated，thanks for your great advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org