You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by jo...@apache.org on 2022/08/02 12:49:21 UTC
[arrow] branch master updated: ARROW-17084: [R] Install the package before linting (#13620)
This is an automated email from the ASF dual-hosted git repository.
jonkeane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 51eb3c8adb ARROW-17084: [R] Install the package before linting (#13620)
51eb3c8adb is described below
commit 51eb3c8adb5742f8d0d05c2e371dfbc651499614
Author: Dragoș Moldovan-Grünfeld <dr...@gmail.com>
AuthorDate: Tue Aug 2 13:49:15 2022 +0100
ARROW-17084: [R] Install the package before linting (#13620)
The package should be installed before running `lintr::ling_package()` or `lintr::expect_lint_free()` (our case), otherwise we could encounter some false positives.
See https://github.com/r-lib/lintr/issues/352#issuecomment-587004345 and https://github.com/r-lib/lintr/issues/406#issuecomment-534601141
Authored-by: Dragoș Moldovan-Grünfeld <dr...@gmail.com>
Signed-off-by: Jonathan Keane <jk...@gmail.com>
---
.github/workflows/r.yml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/.github/workflows/r.yml b/.github/workflows/r.yml
index 4a9c605e3b..4f706e3e5b 100644
--- a/.github/workflows/r.yml
+++ b/.github/workflows/r.yml
@@ -327,6 +327,14 @@ jobs:
shell: Rscript {0}
working-directory: r
run: |
+ Sys.setenv(
+ RWINLIB_LOCAL = file.path(Sys.getenv("GITHUB_WORKSPACE"), "r", "windows", "libarrow.zip"),
+ MAKEFLAGS = paste0("-j", parallel::detectCores()),
+ ARROW_R_DEV = TRUE,
+ "_R_CHECK_FORCE_SUGGESTS_" = FALSE
+ )
+ # we use pak for package installation since it is faster, safer and more convenient
+ pak::local_install()
pak::pak("lintr")
lintr::expect_lint_free()
- name: Dump install logs