You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/30 04:13:36 UTC

[GitHub] [pulsar] merlimat opened a new pull request #5079: Use "info" as the default root logger level

merlimat opened a new pull request #5079: Use "info" as the default root logger level
URL: https://github.com/apache/pulsar/pull/5079
 
 
   # Motivation
   
   In #3661 the root logger level was made configurable and the level was changed from `info` to `debug`. 
   
   That change had the side effect that the control: 
   
   ```java
   if (log.isDebugEnabled()) {
     log.debug("{}", computeExpensiveString());
   }
   ```
   
   is now passing the `if` condition and it's triggering the call to `computeExpensiveString()` whose value is then never printed. This happens for all non pulsar logger (eg. `org.apache.zookeeper..` client logs), with the result of lot of garbage getting created.
   
   Changing back the default value to info.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services