You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Suran Jayathilaka <su...@gmail.com> on 2008/06/13 19:25:23 UTC

DERBY-3706 - Editing message properties files to remove timestamp placeholders

Hi,

This In relation to https://issues.apache.org/jira/browse/DERBY-3706 .

A consistent way of printing a timestamp with all console messages
would mean doing so in the NetworkServerControlImpl.consoleMessage()
method.
However, this would be redundant for messages that are passed in to
consoleMessage() with a timestamp already included.

e.g.
Server start and shutdown messages localized from
messages_<lang>.propertes will have timestamps set in them, since they
have placeholders for a timestamp.

DRDA_Ready.I={1} Network Server - {2} started and ready to accept
connections on port {0} at {3}


Therefore, if consoleMessage() is to add the timestamps to every
message, it would be necessary to edit these properties files to
remove the timestamp placeholders from those message.

e.g.

DRDA_Ready.I={1} Network Server - {2} started and ready to accept
connections on port {0}

Is this appropriate? Is there a reason why this kind of a change
should not be applied?

Thanks.
Suran

Re: DERBY-3706 - Editing message properties files to remove timestamp placeholders

Posted by Bryan Pendleton <bp...@amberpoint.com>.
> I found 4 messages in the messages messages_<lang>.properties file,
> namely the startup and shutdown messages.
> 
> With the propsed changed to consoleMessag(), without editing the
> messages the output would be like
> -----------------------------------
> Security manager installed using the Basic server security policy. at
> 2008-06-17 17:13:54.718 GMT
> Apache Derby Network Server - 10.5.0.0 alpha - (668741M) started and
> ready to accept connections on port 1527 at 2008-06-17 17:13:55.140
> GMT  at 2008-06-17 17:13:55.140 GMT

I agree, this does look a bit awkward, seems like it would be nice
to revise those 4 messages as part of your proposed change.

Thanks for taking the time to explain the issue in more detail.

bryan

Re: DERBY-3706 - Editing message properties files to remove timestamp placeholders

Posted by Suran Jayathilaka <su...@gmail.com>.
Hi,

Sorry about the delay in replying.

I found 4 messages in the messages messages_<lang>.properties file,
namely the startup and shutdown messages.

With the propsed changed to consoleMessag(), without editing the
messages the output would be like
-----------------------------------
Security manager installed using the Basic server security policy. at
2008-06-17 17:13:54.718 GMT
Apache Derby Network Server - 10.5.0.0 alpha - (668741M) started and
ready to accept connections on port 1527 at 2008-06-17 17:13:55.140
GMT  at 2008-06-17 17:13:55.140 GMT
Apache Derby Network Server - 10.5.0.0 alpha - (668741M) shutdown at
2008-06-17 17:14:09.796 GMT at 2008-06-17 17:14:09.796 GMT
------------------------------------

Whereas, with the messages edited to remove the timestamp placeholder,
the output is
----------------------------
Security manager installed using the Basic server security policy. at
2008-06-17 17:04:38.718 GMT
Apache Derby Network Server - 10.5.0.0 alpha - (668741M) started and
ready to accept connections on port 1527  at 2008-06-17 17:04:48.218
GMT
Apache Derby Network Server - 10.5.0.0 alpha - (668741M) shutdown at
2008-06-17 17:05:43.375 GMT
-----------------------

Thanks.
Suran

On Sat, Jun 14, 2008 at 9:23 PM, Bryan Pendleton
<bp...@amberpoint.com> wrote:
>> DRDA_Ready.I={1} Network Server - {2} started and ready to accept
>> connections on port {0} at {3}
>>
>> Therefore, if consoleMessage() is to add the timestamps to every
>> message, it would be necessary to edit these properties files to
>> remove the timestamp placeholders from those message.
>
> How many such messages are there? It seems like it would be OK if
> a couple messages had redundant timestamps in them. I think it would
> also be fine to edit those messages to remove the redundant timestamps.
>
> Can you show some examples of how the actual output will look, both
> with and without the redundant timestamps?
>
> thanks,
>
> bryan
>
>

Re: DERBY-3706 - Editing message properties files to remove timestamp placeholders

Posted by Bryan Pendleton <bp...@amberpoint.com>.
> DRDA_Ready.I={1} Network Server - {2} started and ready to accept
> connections on port {0} at {3}
> 
> Therefore, if consoleMessage() is to add the timestamps to every
> message, it would be necessary to edit these properties files to
> remove the timestamp placeholders from those message.

How many such messages are there? It seems like it would be OK if
a couple messages had redundant timestamps in them. I think it would
also be fine to edit those messages to remove the redundant timestamps.

Can you show some examples of how the actual output will look, both
with and without the redundant timestamps?

thanks,

bryan