You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/07/05 06:37:43 UTC
[PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
voonhous opened a new pull request, #19190:
URL: https://github.com/apache/hudi/pull/19190
Replace private/protected static final Logger LOG = LoggerFactory.getLogger(...) with the Lombok @Slf4j annotation across hudi-flink-datasource (main module, version modules flink1.18.x-2.1.x, and tests): add @Slf4j, delete the field and the two org.slf4j imports, and rename LOG -> log.
The AbstractColumnReader classes deliberately log under the Flink parent class name, so they use @Slf4j(topic = "org.apache.flink.formats.parquet.vector.reader.AbstractColumnReader") to keep the logger category identical. No behavior change.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the changes
(or) link to an issue by including `Closes #<issue-number>` for context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in behavior.
Followed by a detailed log of all the changes. Highlight if any code was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
If medium or high, explain what verification was done to mitigate the risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19190:
URL: https://github.com/apache/hudi/pull/19190#issuecomment-4885127248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2da5779f6525637618418b900a59491043fba6ca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2da5779f6525637618418b900a59491043fba6ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2da5779f6525637618418b900a59491043fba6ca UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19190:
URL: https://github.com/apache/hudi/pull/19190#issuecomment-4885503239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2da5779f6525637618418b900a59491043fba6ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15246",
"triggerID" : "2da5779f6525637618418b900a59491043fba6ca",
"triggerType" : "PUSH"
}, {
"hash" : "b77890d4282e1b402baee1d95d6be49933070d66",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15247",
"triggerID" : "b77890d4282e1b402baee1d95d6be49933070d66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b77890d4282e1b402baee1d95d6be49933070d66 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15247)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #19190:
URL: https://github.com/apache/hudi/pull/19190#discussion_r3524437031
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringPlanSourceFunction.java:
##########
@@ -46,10 +45,9 @@
* as the instant time.</li>
* </ul>
*/
+@Slf4j
Review Comment:
🤖 nit: the original field was `protected static final Logger LOG`, meaning subclasses could reference it directly. `@Slf4j` generates `private static final Logger log`, so any existing or future subclass that relied on the inherited `LOG` would break silently at compile time. Could you confirm no subclasses reference `LOG`? If they do (or might), consider keeping the field as a manual `protected` declaration rather than using `@Slf4j` here. Same applies to `CompactionPlanSourceFunction`, `HoodieFlinkClusteringJob`, and `HoodieFlinkCompactor`.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19190:
URL: https://github.com/apache/hudi/pull/19190#issuecomment-4885147405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2da5779f6525637618418b900a59491043fba6ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15246",
"triggerID" : "2da5779f6525637618418b900a59491043fba6ca",
"triggerType" : "PUSH"
}, {
"hash" : "b77890d4282e1b402baee1d95d6be49933070d66",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b77890d4282e1b402baee1d95d6be49933070d66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2da5779f6525637618418b900a59491043fba6ca Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15246)
* b77890d4282e1b402baee1d95d6be49933070d66 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #19190:
URL: https://github.com/apache/hudi/pull/19190#discussion_r3524749803
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringPlanSourceFunction.java:
##########
@@ -46,10 +45,9 @@
* as the instant time.</li>
* </ul>
*/
+@Slf4j
Review Comment:
Confirmed - there are no subclasses of `ClusteringPlanSourceFunction`, `CompactionPlanSourceFunction`, `HoodieFlinkClusteringJob`, or `HoodieFlinkCompactor` anywhere in the repo (`grep -rn 'extends <class>'` returns nothing), so nothing references the inherited `LOG`. The `protected` was over-permissive; the generated `private log` is safe here.
If a subclass ever needs a logger it just adds its own `@Slf4j` (each class gets its own `log`), so there's no cross-class dependency to preserve. Keeping `@Slf4j`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19190:
URL: https://github.com/apache/hudi/pull/19190#issuecomment-4885137444
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2da5779f6525637618418b900a59491043fba6ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15246",
"triggerID" : "2da5779f6525637618418b900a59491043fba6ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2da5779f6525637618418b900a59491043fba6ca Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15246)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19190:
URL: https://github.com/apache/hudi/pull/19190#issuecomment-4885289229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2da5779f6525637618418b900a59491043fba6ca",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15246",
"triggerID" : "2da5779f6525637618418b900a59491043fba6ca",
"triggerType" : "PUSH"
}, {
"hash" : "b77890d4282e1b402baee1d95d6be49933070d66",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15247",
"triggerID" : "b77890d4282e1b402baee1d95d6be49933070d66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2da5779f6525637618418b900a59491043fba6ca Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15246)
* b77890d4282e1b402baee1d95d6be49933070d66 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15247)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(flink): migrate hand-declared LOG to Lombok @Slf4j [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #19190:
URL: https://github.com/apache/hudi/pull/19190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org