You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/24 14:26:00 UTC
[GitHub] [zookeeper] tisonkun opened a new pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
tisonkun opened a new pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826
So far, I add a simplest test executing `bin/zkCli.sh sync /` for testing connectivity.
You can comment to enrich the test script.
This command itself is enough for proceeding the original proposal that merge `readOnly` field into `ConnectRequest` and `ConnectResponse` as it's tested with any successfully setup connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] sonatype-lift[bot] commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r814432522
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
+
+from pathlib import Path
+
+class Server():
+ def __init__(self, binpath):
+ self.binpath = binpath
+ def __enter__(self):
+ subprocess.run([f'{self.binpath}', 'start'], check=True)
+ return self
+ def __exit__(self, type, value, traceback):
+ subprocess.run([f'{self.binpath}', 'stop'], check=True)
+
+if __name__ == '__main__':
+ parser = argparse.ArgumentParser()
+ parser.add_argument('--server', help="basepath to zk server", required=True)
+ parser.add_argument('--client', help="basepath to zk client", required=True)
+
+ args = parser.parse_args()
+
+ server_basepath = Path(args.server).absolute()
+ server_binpath = server_basepath / "bin" / "zkServer.sh"
+ assert server_binpath.exists(), f"server binpath not exist: {server_binpath}"
+ client_basepath = Path(args.client).absolute()
+ client_binpath = client_basepath / "bin" / "zkCli.sh"
+ assert client_binpath.exists(), f"client binpath not exist: {client_binpath}"
+
+ with Server(server_binpath):
+ subprocess.run([f'{client_binpath}', 'sync', '/'], check=True)
Review comment:
I’m LiftBot and I automatically analyze new code in code review, and comment when I find potential bugs. I also accept comments as commands. Just `@sonatype-lift` followed by the command: **ignore** to mark as false positive, **unignore** to undo, and **help** to see this message. [Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
Review comment:
I’m LiftBot and I automatically analyze new code in code review, and comment when I find potential bugs. I also accept comments as commands. Just `@sonatype-lift` followed by the command: **ignore** to mark as false positive, **unignore** to undo, and **help** to see this message. [Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054376142
@symat I think master is enough. This change is enhancement and normally we pick bugfix only. Also I don't need it for any previous releases but for polishing the codebase.
If we grow more it cases and find them benefits releasing branches, we can pick to them later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] sonatype-lift[bot] commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r814433000
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
Review comment:
I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1051015112
I think the CI failure is about:
* https://github.com/apache/zookeeper/pull/1827
* https://github.com/apache/zookeeper/pull/1825
@eolivelli you can give this another look now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r814432991
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
Review comment:
@sonatype-lift ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1050461863
I don't know why build-cppunit-tests failed, obviously I don't touch any files about it ：）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r813935061
##########
File path: .github/workflows/e2e.yaml
##########
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: End to End Tests
+
+on:
+ push:
+ pull_request:
+
+jobs:
+ connectivity:
+ strategy:
+ matrix:
+ jdk: [8, 11]
+ fail-fast: false
+ timeout-minutes: 360
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.jdk }}
+ - name: Cache local maven repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/zookeeper
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Install C Dependencies
+ run: sudo apt-get install libcppunit-dev libsasl2-dev
+ - name: Build with Maven
+ run: mvn -B -V -e -ntp "-Dstyle.color=always" package -DskipTests
+ env:
+ MAVEN_OPTS: -Djansi.force=true
+ - name: Test ZooKeeper nightly server and client
+ run: |
+ cp conf/zoo_sample.cfg conf/zoo.cfg
+ bin/zkServer.sh start
+ bin/zkCli.sh sync /
+ bin/zkServer.sh stop
+
+ compatibility:
+ strategy:
+ matrix:
+ jdk: [8, 11]
+ zk: [3.5.9, 3.6.3, 3.7.0]
+ fail-fast: false
+ timeout-minutes: 360
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: Set up JDK ${{ matrix.jdk }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.jdk }}
+ - name: Cache local maven repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/zookeeper
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Install C Dependencies
+ run: sudo apt-get install libcppunit-dev libsasl2-dev
+ - name: Build with Maven
+ run: mvn -B -V -e -ntp "-Dstyle.color=always" package -DskipTests
+ env:
+ MAVEN_OPTS: -Djansi.force=true
+ - name: Download ZooKeeper ${{ matrix.zk }} and prepare config
+ run: |
+ curl -O https://downloads.apache.org/zookeeper/zookeeper-${{ matrix.zk }}/apache-zookeeper-${{ matrix.zk }}-bin.tar.gz
Review comment:
Possibly use http://archive.apache.org/dist/zookeeper/ for stability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054375299
Master is enough.
We aren't going to commit possible breaking changes to release branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1051404735
Thanks for your review!
cc @maoling @anmolnar @hanm could you take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] sonatype-lift[bot] commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r814435523
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
+
+from pathlib import Path
+
+class Server():
+ def __init__(self, binpath):
+ self.binpath = binpath
+ def __enter__(self):
+ subprocess.run([f'{self.binpath}', 'start'], check=True)
+ return self
+ def __exit__(self, type, value, traceback):
+ subprocess.run([f'{self.binpath}', 'stop'], check=True)
+
+if __name__ == '__main__':
+ parser = argparse.ArgumentParser()
+ parser.add_argument('--server', help="basepath to zk server", required=True)
+ parser.add_argument('--client', help="basepath to zk client", required=True)
+
+ args = parser.parse_args()
+
+ server_basepath = Path(args.server).absolute()
+ server_binpath = server_basepath / "bin" / "zkServer.sh"
+ assert server_binpath.exists(), f"server binpath not exist: {server_binpath}"
+ client_basepath = Path(args.client).absolute()
+ client_binpath = client_basepath / "bin" / "zkCli.sh"
+ assert client_binpath.exists(), f"client binpath not exist: {client_binpath}"
+
+ with Server(server_binpath):
+ subprocess.run([f'{client_binpath}', 'sync', '/'], check=True)
Review comment:
I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1050452622
@eolivelli updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] sonatype-lift[bot] commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r814430039
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
Review comment:
*blacklist:* Consider possible security implications associated with the subprocess module.
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
+
+from pathlib import Path
+
+class Server():
+ def __init__(self, binpath):
+ self.binpath = binpath
+ def __enter__(self):
+ subprocess.run([f'{self.binpath}', 'start'], check=True)
+ return self
+ def __exit__(self, type, value, traceback):
+ subprocess.run([f'{self.binpath}', 'stop'], check=True)
+
+if __name__ == '__main__':
+ parser = argparse.ArgumentParser()
+ parser.add_argument('--server', help="basepath to zk server", required=True)
+ parser.add_argument('--client', help="basepath to zk client", required=True)
+
+ args = parser.parse_args()
+
+ server_basepath = Path(args.server).absolute()
+ server_binpath = server_basepath / "bin" / "zkServer.sh"
+ assert server_binpath.exists(), f"server binpath not exist: {server_binpath}"
+ client_basepath = Path(args.client).absolute()
+ client_binpath = client_basepath / "bin" / "zkCli.sh"
+ assert client_binpath.exists(), f"client binpath not exist: {client_binpath}"
+
+ with Server(server_binpath):
+ subprocess.run([f'{client_binpath}', 'sync', '/'], check=True)
Review comment:
*subprocess_without_shell_equals_true:* subprocess call - check for execution of untrusted input.
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054372551
sure, I'm merging it now.
Master branch is enough? Or should I cherry-pick?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1054369998
@symat Thanks for your review! May you or @eolivelli help on merging this PR? I'm going to prepare a patch achieving the original proposal on connect request codec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r814432485
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
+
+from pathlib import Path
+
+class Server():
+ def __init__(self, binpath):
+ self.binpath = binpath
+ def __enter__(self):
+ subprocess.run([f'{self.binpath}', 'start'], check=True)
+ return self
+ def __exit__(self, type, value, traceback):
+ subprocess.run([f'{self.binpath}', 'stop'], check=True)
+
+if __name__ == '__main__':
+ parser = argparse.ArgumentParser()
+ parser.add_argument('--server', help="basepath to zk server", required=True)
+ parser.add_argument('--client', help="basepath to zk client", required=True)
+
+ args = parser.parse_args()
+
+ server_basepath = Path(args.server).absolute()
+ server_binpath = server_basepath / "bin" / "zkServer.sh"
+ assert server_binpath.exists(), f"server binpath not exist: {server_binpath}"
+ client_basepath = Path(args.client).absolute()
+ client_binpath = client_basepath / "bin" / "zkCli.sh"
+ assert client_binpath.exists(), f"client binpath not exist: {client_binpath}"
+
+ with Server(server_binpath):
+ subprocess.run([f'{client_binpath}', 'sync', '/'], check=True)
Review comment:
@sonatype-lift help
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
Review comment:
@sonatype-lift help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on a change in pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#discussion_r814435497
##########
File path: tools/ci/test-connectivity.py
##########
@@ -0,0 +1,48 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import argparse
+import subprocess
+
+from pathlib import Path
+
+class Server():
+ def __init__(self, binpath):
+ self.binpath = binpath
+ def __enter__(self):
+ subprocess.run([f'{self.binpath}', 'start'], check=True)
+ return self
+ def __exit__(self, type, value, traceback):
+ subprocess.run([f'{self.binpath}', 'stop'], check=True)
+
+if __name__ == '__main__':
+ parser = argparse.ArgumentParser()
+ parser.add_argument('--server', help="basepath to zk server", required=True)
+ parser.add_argument('--client', help="basepath to zk client", required=True)
+
+ args = parser.parse_args()
+
+ server_basepath = Path(args.server).absolute()
+ server_binpath = server_basepath / "bin" / "zkServer.sh"
+ assert server_binpath.exists(), f"server binpath not exist: {server_binpath}"
+ client_basepath = Path(args.client).absolute()
+ client_binpath = client_basepath / "bin" / "zkCli.sh"
+ assert client_binpath.exists(), f"client binpath not exist: {client_binpath}"
+
+ with Server(server_binpath):
+ subprocess.run([f'{client_binpath}', 'sync', '/'], check=True)
Review comment:
@sonatype-lift ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun edited a comment on pull request #1826: ZOOKEEPER-4480: Introduce end to end compatibility tests
Posted by GitBox <gi...@apache.org>.
tisonkun edited a comment on pull request #1826:
URL: https://github.com/apache/zookeeper/pull/1826#issuecomment-1050461863
I don't know why build-cppunit-tests failed, obviously I don't touch any files about it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org