[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #12154: feat: move filters from superset-ui to incubator

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #12154:
URL: https://github.com/apache/incubator-superset/pull/12154#issuecomment-749947096


   Hi @simchaNielsen Thanks for the PR. I think the advantage to have native filter component in superset core js codebase is obvious: quicker development cycle, easier to share function or components with other `dashboard` components. 
   
   But since filter component was a superset-ui plugin, may i know what is original architectural design consideration? 
   After moving it to superset core js, can we use/build filter component as regular dashboard component, or still need to treat native filter like other plugin? cc @villebro 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org