You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "IamJeffG (via GitHub)" <gi...@apache.org> on 2023/03/22 17:05:42 UTC
[GitHub] [superset] IamJeffG opened a new issue, #23456: Language Selection doesn't always switch language
IamJeffG opened a new issue, #23456:
URL: https://github.com/apache/superset/issues/23456
Language Selection doesn't always switch language
#### How to reproduce the bug
1. Run superset with `LANGUAGES` set in config. I'm using `LANGUAGES={"en": {"flag": "us", "name": "English"}, "pt_BR": {"flag": "br", "name": "Português"}, "es": {"flag": "mx", "name": "Español"}, "fr": {"flag": "fr", "name": "Français"}, "nl": {"flag": "sr", "name": "Nederlands"}}`
2. Open web browser. You can replicate this from any page, including before logging in.
4. Click the flag in the top-right corner. Select a different language.
5. The page flashes to refresh in the new language. Sometimes (not always) the language has changed, sometimes you are still seeing the old language!
### Expected results
The page flash to refresh is fine. But afterward it should show the language I just clicked on.
### Actual results
Sometimes you are still seeing the old language after having clicked a different one.
#### Screenshots
### Environment
**I did not** see this bug when running `apache/superset:2.0.1`
**I do see this bug** running from the docker image `apache/superset:2.1.0rc3`.
- browser type and version: Firefox 111.0 (64-bit) on Linux. Also Chromium Version 111.0.5563.64 (Official Build) (64-bit) on Linux
- superset version: `Superset 2.1.0`
- python version: `Python 3.8.16`
- node.js version:
```
$ docker exec -it superset_app node -v
OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: exec: "node": executable file not found in $PATH: unknown
```
- any feature flags active:
```
FEATURE_FLAGS = {
"ALERT_REPORTS": True,
}
```
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
* no errors, just logs from the `/lang/en` route and other routes needed for the current page.
- [x] I have reproduced the issue with at least the latest released version of superset.
* no bug on 2.0.1
* bug on 2.1.0rc3
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mpostelnicu commented on issue #23456: Language Selection doesn't always switch language
Posted by "mpostelnicu (via GitHub)" <gi...@apache.org>.
mpostelnicu commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1645917821
still happening in [2.1.1rc2](https://github.com/apache/superset/releases/tag/2.1.1rc2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "q631599119 (via GitHub)" <gi...@apache.org>.
q631599119 commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-2530522792
now I'm on master but this bug is still actual,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-2155646920
Weird... I'm on `master` but I'm able two switch between all languages, including both Portuguese variants. Are you getting any browser console errors or server errors or something? Do you have any customized Superset code that might not be handling redirects correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-2148549099
@AghastyGD in which version of Superset? I was able to switch languages no problem on current `master`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-pervushin commented on issue #23456: Language Selection doesn't always switch language
Posted by "andrey-pervushin (via GitHub)" <gi...@apache.org>.
andrey-pervushin commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1542142673
this bug is still actual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] evvs commented on issue #23456: Language Selection doesn't always switch language
Posted by "evvs (via GitHub)" <gi...@apache.org>.
evvs commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1513416735
> We encountered the same problem. Changing the language works fine in versions 2.0.0 and 2.0.1, but it doesn't work as expected in version 2.1.0rc3.
We have the same issue. That's why we don't update to the latest version ☹️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "AghastyGD (via GitHub)" <gi...@apache.org>.
AghastyGD commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-2148993985
> @AghastyGD in which version of Superset? I was able to switch languages no problem on current `master`
@rusackas I am using the version 4.0.1 from PyPi Package, when I change to Brazilian the screen goes into blank with an infinite loading of superset logo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "AghastyGD (via GitHub)" <gi...@apache.org>.
AghastyGD commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-2141965441
> this bug is still actual
yes, it's still with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] IamJeffG commented on issue #23456: Language Selection doesn't always switch language
Posted by "IamJeffG (via GitHub)" <gi...@apache.org>.
IamJeffG commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1480085973
This might be less straightforward than stated above. I also see some slightly different (but still buggy) behaviors:
* Once in a blue moon, I'll select a different language; the current page won't change language, as described above. But then I navigate to a new page and that new page is in the desired language.
* I've also seen cases where the page text does change to my new language but the flag icon doesn't:
> 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "AghastyGD (via GitHub)" <gi...@apache.org>.
AghastyGD commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-2160069858
Hi, thank you for your assistance, I was making a small mistake in the language selection in the feature flags, I was using "br" instead of "pt-BR", I just changed that, and now it's working correctly. that's why it was giving me this error in the console:
just changed to this:
I'm sorry for any misunderstandings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mpostelnicu commented on issue #23456: Language Selection doesn't always switch language
Posted by "mpostelnicu (via GitHub)" <gi...@apache.org>.
mpostelnicu commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1622605689
same issue in 2.1.1rc1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dawnmarch commented on issue #23456: Language Selection doesn't always switch language
Posted by "dawnmarch (via GitHub)" <gi...@apache.org>.
dawnmarch commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1489741912
We encountered the same problem. Changing the language works fine in versions 2.0.0 and 2.0.1, but it doesn't work as expected in version 2.1.0rc3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #23456: Language Selection doesn't always switch language
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1622707396
Thank you for reporting this. We'll find someone to take a look, unless anyone else wants to open a PR for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23456:
URL: https://github.com/apache/superset/issues/23456#issuecomment-1981866448
I believe this was resolved by the linked PR, but the issue was never closed. Closing now, bu happy to revisit if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Language Selection doesn't always switch language [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #23456: Language Selection doesn't always switch language
URL: https://github.com/apache/superset/issues/23456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org