[GitHub] [lucenenet] NightOwl888 opened a new pull request #528: Migrated from System.Collections.Generic.List to J2N.Collections.Generic.List

[GitBox <gi...@apache.org>]

NightOwl888 opened a new pull request #528:
URL: https://github.com/apache/lucenenet/pull/528


   J2N's `List<T>` provides structural equality and structural formatting, which make it simpler to use in conjunction with Lucene and for debug/logging purposes. This replaces all instances of `System.Collections.Generic.List<T>` to `J2N.Collections.Generic.List<T>`.
   
   3 protected fields were updated from `System.Collections.Generic.List<T>` to `System.Collections.Generic.IList<T>`. This is a breaking change, but the impact is low for most users.
   
   - src/Lucene.Net.Analysis.Stempel/Egothor.Stemmer/MultiTrie (m_tries)
   - src/Lucene.Net/Search/BooleanQuery.cs (m_weights)
   - src/Lucene.Net/Search/DisjunctionMaxQuery.cs (m_weights)
   
   The changed to `J2N.Collections.Generic.List<T>` revealed a false positive in `TestFreeTextSuggester`, which was also fixed. The fix had no additional impact on the production code.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 merged pull request #528: Migrated from System.Collections.Generic.List to J2N.Collections.Generic.List

[GitBox <gi...@apache.org>]

NightOwl888 merged pull request #528:
URL: https://github.com/apache/lucenenet/pull/528


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org