[GitHub] [tvm] areusch commented on a diff in pull request #11380: [ci] Restructure Jenkinsfile

[GitBox <gi...@apache.org>]

areusch commented on code in PR #11380:
URL: https://github.com/apache/tvm/pull/11380#discussion_r878528822


##########
jenkins/Jenkinsfile.j2:
##########
@@ -407,503 +99,29 @@ def make(docker_type, path, make_flag) {
 {% set microtvm_template_projects = ['build/microtvm_template_projects',] %}
 s3_prefix = "tvm-jenkins-artifacts-prod/tvm/${env.BRANCH_NAME}/${env.BUILD_NUMBER}"
 
+// General note: Jenkins has limits on the size of a method (or top level code)
+// that are pretty strict, so most usage of groovy methods in these templates
+// are purely to satisfy the JVM
+{% include "jenkins/Prepare.groovy.j2" %}

Review Comment:
   is there a script you run to regenerate this file? i always invoke from a venv inside of jenkins (though I guess maybe that's not necessary now that we've added it to the docker containers). in any case, now that we have paths involved, i think it would be good to fully capture the build recipe here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org