You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Neil Griffin (JIRA)" <ji...@apache.org> on 2018/10/08 22:38:00 UTC

[jira] [Comment Edited] (PLUTO-734) TCK: Contesting AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions

    [ https://issues.apache.org/jira/browse/PLUTO-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617897#comment-16617897 ] 

Neil Griffin edited comment on PLUTO-734 at 10/8/18 10:37 PM:
--------------------------------------------------------------

Fixed in commits [e9937bf853670a4f957adc01f6a4a98fa2f41a1c|https://github.com/apache/portals-pluto/commit/e9937bf853670a4f957adc01f6a4a98fa2f41a1c] and [959a107365e1aaf5d767e78657475039a9e25b74|https://github.com/apache/portals-pluto/commit/959a107365e1aaf5d767e78657475039a9e25b74].


was (Author: ngriffin7a):
Fixed in commit [e9937bf853670a4f957adc01f6a4a98fa2f41a1c|https://github.com/apache/portals-pluto/commit/e9937bf853670a4f957adc01f6a4a98fa2f41a1c]

> TCK: Contesting AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions
> -----------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-734
>                 URL: https://issues.apache.org/jira/browse/PLUTO-734
>             Project: Pluto
>          Issue Type: Test
>          Components: tck
>    Affects Versions: 3.0.0, 3.0.1
>            Reporter: Neil Griffin
>            Assignee: Neil Griffin
>            Priority: Major
>             Fix For: 3.0.2
>
>
> Similar to PLUTO-715, AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions assumes that all implementations of Portlet 3.0 will support the following runtime options:
> {code:java|title= AnnotationPortletAppConfigOverrideTests_SPEC1_28_PortletContainerRuntimeOptions.java}
>          if(runtimeOptions.containsKey("javax.portlet.escapeXml") 
>                && runtimeOptions.containsKey("javax.portlet.actionScopedRequestAttributes")
>                && runtimeOptions.get("javax.portlet.escapeXml")[0].equals("true")
>                && runtimeOptions.get("javax.portlet.actionScopedRequestAttributes")[0].equals("true")){
>             result.setTcSuccess(true);
>          }
> {code}
> The problem is that the {{javax.portlet.actionScopedRequestAttributes}} container-runtime-option is optional.
> Similar to the solution for fixing PLUTO-715, this issue serves as a task for introducing "pluto" and "liferay" maven profiles that account for the differences.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)