You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/16 08:44:24 UTC

[GitHub] [doris] HackToday commented on a diff in pull request #15972: [improvement](bitshuffle)Enable avx512 support in bitshuffle for performance boost

HackToday commented on code in PR #15972:
URL: https://github.com/apache/doris/pull/15972#discussion_r1070966141


##########
be/src/gutil/cpu.cc:
##########
@@ -253,6 +256,7 @@ void CPU::Initialize() {
 #endif
 }
 CPU::IntelMicroArchitecture CPU::GetIntelMicroArchitecture() const {
+    if (has_avx512()) return AVX512;

Review Comment:
   It seems old code not use braces. so not sure if needed to change all if case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org