You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/22 05:33:07 UTC
[GitHub] [pulsar-site] tisonkun opened a new pull request, #219: Redirect develop-binary-protocol to developing-binary-protocol
tisonkun opened a new pull request, #219:
URL: https://github.com/apache/pulsar-site/pull/219
This closes https://github.com/apache/pulsar/issues/17791
cc @lhotari @dave2wave @michaeljmarshall @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] lhotari merged pull request #219: Redirect develop-binary-protocol to developing-binary-protocol
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #219:
URL: https://github.com/apache/pulsar-site/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #219: Redirect develop-binary-protocol to developing-binary-protocol
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #219:
URL: https://github.com/apache/pulsar-site/pull/219#discussion_r977222170
##########
content/.htaccess:
##########
@@ -3,3 +3,5 @@ RewriteEngine On
RewriteRule "^en/(.+)$" "/$1" [R=301,DPI,L]
RewriteRule "^docs/en/(.+)$" "/docs/$1" [R=301,DPI,L]
RewriteRule "^docs/(zh-CN|zh-TW|ja|ko|fr)/(.+)$" "/$1/docs/$2" [R=301,DPI,L]
Review Comment:
```suggestion
RewriteRule "^en/(.+)$" "/$1" [R=301,DPI]
RewriteRule "^docs/en/(.+)$" "/docs/$1" [R=301,DPI]
RewriteRule "^docs/(zh-CN|zh-TW|ja|ko|fr)/(.+)$" "/$1/docs/$2" [R=301,DPI]
```
Perhaps now we cannot set these rules with `L`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #219: Redirect develop-binary-protocol to developing-binary-protocol
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #219:
URL: https://github.com/apache/pulsar-site/pull/219#discussion_r977216256
##########
content/.htaccess:
##########
@@ -3,3 +3,5 @@ RewriteEngine On
RewriteRule "^en/(.+)$" "/$1" [R=301,DPI,L]
RewriteRule "^docs/en/(.+)$" "/docs/$1" [R=301,DPI,L]
RewriteRule "^docs/(zh-CN|zh-TW|ja|ko|fr)/(.+)$" "/$1/docs/$2" [R=301,DPI,L]
+
+RewriteRule "^docs/(.+)/develop-binary-protocol(.*)$" "/docs/$1/developing-binary-protocol$2" [R=301,DPI,L]
Review Comment:
```suggestion
RewriteRule "^docs/(.*)develop-binary-protocol(.*)$" "/docs/$1developing-binary-protocol$2" [R=301,DPI,L]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org