You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/08 05:46:20 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #14595: Fix potential npe bug of #14384
gaozhangmin opened a new pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595
### Motivation
Fix potential np bug
### Modifications
Fix potential np bug
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14595: Fix potential npe bug of #14384
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061483640
@gaozhangmin Please add some tests to cover this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14595: Fix potential npe bug of #14384
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061428391
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14595: Fix potential npe bug of #14384
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061615775
> > @gaozhangmin Please add some tests to cover this change.
>
> The tests were already covered by `BookKeeperPackagesStorageTest.java`. But need to change `zookeeperServers` to `metadataStoreUrl` @lhotari
ok, that explains. At the time I checked the PR there was a fix, but no test changes and that's why I made the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14595: Fix potential npe bug of #14384
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061501152
> @gaozhangmin Please add some tests to cover this change.
The tests were already covered by `BookKeeperPackagesStorageTest.java`. But need to change `zookeeperServers` to `metadataStoreUrl` @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14595: Fix potential npe bug of #14384
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14595: Fix potential npe bug of #14384
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061504085
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14595: Fix potential npe bug of #14384
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14595:
URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061428453
@gaozhangmin:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org