[GitHub] [helix] dasahcc commented on a change in pull request #431: Refine the WAGED rebalancer related interfaces for integration

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #431: Refine the WAGED rebalancer related interfaces for integration
URL: https://github.com/apache/helix/pull/431#discussion_r317792466
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
 ##########
 @@ -111,19 +116,45 @@ private BestPossibleStateOutput compute(ClusterEvent event, Map<String, Resource
     boolean isValid = validateOfflineInstancesLimit(cache,
         (HelixManager) event.getAttribute(AttributeName.helixmanager.name()));
 
+    // 1. Rebalance with the global rebalancer
+    // The rebalancer will calculate the new ideal assignment for all the compatible resources.
+    Map<String, IdealState> globalRebalanceResult = new HashMap<>();
+    GlobalRebalancer globalRebalancer = new WagedRebalancer(helixManager);
 
 Review comment:
   Why not have a flag to mark global rebalancer enabled or not? Otherwise, for each pipeline, it will do a global computation first then move to single resource computation when it fails? Could that be inefficient?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org