[GitHub] [pulsar] yabinmeng edited a comment on issue #9549: Pulsar topic compaction through "pulsar compact-topic" is not working

[GitBox <gi...@apache.org>]

yabinmeng edited a comment on issue #9549:
URL: https://github.com/apache/pulsar/issues/9549#issuecomment-778290565


   @WJL3333 Yes, I have `brokerServicePortTls` set with port 6551. But `**tlsEnabled**` is set as false and other TLS related settings (e.g. `tlsCertificateFilePath` etc.) are empty
   ```
   brokerServicePort=6650
   brokerServicePortTls=6651
   tlsEnabled=false
   tlsCertificateFilePath=
   ```
   
   Now I do see in broker.conf comment it says that `tlsEnabled` is deprecated (and the code indeed does the only check of the existence of tls port). For "deprecated" feature/setting, my understanding is that the old setting should still be supported until it is officially removed.  Before then, both the old setting and new setting should be respected. When both settings are present, the old one should take precedence.
   
   Also, after a quick search of `tlsEnabled` in the code base and looks like it is still respected in a few other places (e.g. PulsarChannelInitializer.java); but not in other places. This is a bit confusing. 
   
   The official document (2.7.0) is also still based on the check of `tlsEnabled`:
   https://pulsar.apache.org/docs/en/security-tls-transport/#broker-configuration
   
   Looks like we can do some improvement here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org