You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/11/20 05:04:59 UTC
[kudu-CR] [util] more information on fault injection
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11960
Change subject: [util] more information on fault injection
......................................................................
[util] more information on fault injection
Log more information on injected fault: name of the process and PID.
That helps to parse concatenated logs: e.g., that useful in parsing
logs from scenarios run via dist-test.
Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61
---
M src/kudu/util/fault_injection.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11960/1
--
To view, visit http://gerrit.cloudera.org:8080/11960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61
Gerrit-Change-Number: 11960
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] more information on fault injection
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11960 )
Change subject: [util] more information on fault injection
......................................................................
[util] more information on fault injection
Log more information on injected fault: name of the process and PID.
That helps to parse concatenated logs: e.g., that useful in parsing
logs from scenarios run via dist-test.
Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61
Reviewed-on: http://gerrit.cloudera.org:8080/11960
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/util/fault_injection.cc
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61
Gerrit-Change-Number: 11960
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [util] more information on fault injection
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11960
to look at the new patch set (#2).
Change subject: [util] more information on fault injection
......................................................................
[util] more information on fault injection
Log more information on injected fault: name of the process and PID.
That helps to parse concatenated logs: e.g., that useful in parsing
logs from scenarios run via dist-test.
Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61
---
M src/kudu/util/fault_injection.cc
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/11960/2
--
To view, visit http://gerrit.cloudera.org:8080/11960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61
Gerrit-Change-Number: 11960
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] more information on fault injection
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11960 )
Change subject: [util] more information on fault injection
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0f094006a89fd271091d1bde13d301ea359ae61
Gerrit-Change-Number: 11960
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 07:07:50 +0000
Gerrit-HasComments: No